Page MenuHomeFreeBSD

Add cpuset(2) support to sepearate forked processes.
ClosedPublic

Authored by gnn on Sep 2 2016, 9:14 PM.
Tags
None
Referenced Files
F86980524: D7766.diff
Fri, Jun 28, 12:23 AM
Unknown Object (File)
May 17 2024, 11:34 PM
Unknown Object (File)
Feb 24 2024, 1:24 PM
Unknown Object (File)
Jan 4 2024, 6:50 AM
Unknown Object (File)
Dec 20 2023, 12:17 AM
Unknown Object (File)
Oct 26 2023, 6:57 AM
Unknown Object (File)
Oct 24 2023, 11:53 PM
Unknown Object (File)
Sep 27 2023, 1:17 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5018
Build 5087: arc lint + arc unit

Event Timeline

gnn retitled this revision from to Add cpuset(2) support to sepearate forked processes..
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
tools/tools/crypto/cryptotest.c
469–473

threads is an arbitrary user-provided atoi() value and may exceed the logical range of the cpuset_t mask, corrupting the stack (BIT_SET doesn't bounds check).

gnn marked an inline comment as done.Sep 2 2016, 10:30 PM

Address issue of too many threads.

Looks good other than these nits.

tools/tools/crypto/cryptotest.c
581

This isn't quite right either — sizeof(cpuset_t) * NBBY would be closer, but I'd just use the named constant CPU_SETSIZE from sys/_cpuset.h.

582

Perhaps: "choose fewer than %d.", ..., CPU_SETSIZE

gnn marked an inline comment as done.Sep 3 2016, 12:20 AM

I've address the main issues.

tools/tools/crypto/cryptotest.c
582

This is a play on the old Apple compiler message: "Too many errors, make fewer."

This revision was automatically updated to reflect the committed changes.

LGTM. (I think the old compiler message only ever got notoriety because of how unhelpful it was; not something to aspire to. But whatever.)