In D6572#138990, @cem wrote:

I don't dislike the if() { } cleanup pattern on exit, even if it is impossible with today's code.

Does this code ever get compiled in userspace? Do the mem_alloc routines do the same thing there?

Looks fine to me.

Match existing {} style

Closed by commit rS300686: Fix a couple of Coverity Unintended sign extension sign extension (authored by truckman).

Closed by commit : rS300685: Fix a couple of new instances of a false positive Coverity buffer (authored by truckman).

Clear cdb_storage before reusing it.

dup

Whitespace changes

Re-order the tests in the name sanitization loop to eliminate the else clause

Return early when possible to reduce code nesting.

I like the early return idea, though it will make the diff a lot bigger.

In D6496#137886, @imp wrote:

I like the code cleanup, but foo[1] is a time-honored technique to get the address following foo. I'm surprised this would be flagged as an error.

Any thoughts about MFC to 10-STABLE?

I just counted 'em up and found that this is responsible for 77 Coverity errors.