HomeFreeBSD

Fix acpidump CID 1011278 (Buffer not null terminated) and other issues

Description

Fix acpidump CID 1011278 (Buffer not null terminated) and other issues

Coverity reports that a buffer used for temporary file generation
might not be NUL terminated by strncpy(). This is probably not
true because the input gets passed through realpath(), but if the
path name is sufficiently long the name could be truncated and cause
other problems. The code for generating the temp file names is
also overly complex. Instead of a bunch of calls to strncpy() and
and strncat(), simplify the code by using snprintf() and add checks
for unexpected truncation.

The output file created by iasl -d is predictable. Fix this by
using mkdtemp() to create a directory to hold the iasl input and
output files.

Check the return values of more syscalls.

Reported by: Coverity
CID: 1011278
Reviewed by: jkim
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6360

Details

Provenance
truckmanAuthored on
Reviewer
jkim
Differential Revision
D6360: Fix acpidump CID 1011278 (Buffer not null terminated) and other issues
Parents
rS300631: Regenerate
Branches
Unknown
Tags
Unknown