In D31150#712854, @whu wrote:Update the review, incorporate some review comments from Dexuan.
- Rename mana_trc_dbg and likes to mana_dbg, etc.
- Fixed some comments.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 19 2021
Aug 19 2021
Jul 17 2018
Jul 17 2018
Looks good to me. I'll commit it shortly.
May 1 2018
May 1 2018
decui_microsoft.com added a comment to D598: net: move interface removal notification up in if_detach_internal.
In D598#321169, @royger wrote:Done, MFC'ed as r333106.
Apr 26 2018
Apr 26 2018
decui_microsoft.com added a comment to D598: net: move interface removal notification up in if_detach_internal.
I'm hitting a panic with stable/10. Can you please MFC this patch form the HEAD to stable/10?
Mar 23 2018
Mar 23 2018
decui_microsoft.com added a comment to D14690: hyperv/storvsc: storvsc_io_done(): do not use CAM_SEL_TIMEOUT.
If there is no new comment, I'm going to commit the patch next week.
Mar 14 2018
Mar 14 2018
decui_microsoft.com added a comment to D14690: hyperv/storvsc: storvsc_io_done(): do not use CAM_SEL_TIMEOUT.
I manually tested the patch with releng/{10.3, 10.4, 11.0, 11.1}, stable/{10, 11), and master on local Windows Server 2012 R2, 2016 and Azure, and I don't hit any regression. For Azure testing, I created multiple VMs (Standard D4 v2 (8 vcpus, 28 GB memory) ) in West Central US region and ran a lot of "hot add/remove disks" tests, e.g.
a) hot add and remove a disk on LUN0
b) hot add and remove a disk on LUN1
c) hot add and remove a disk on LUN9
d) hot add and remove a disk on LUN0, and LUN9
e) hot add and remove a disk on LUN1, and LUN9
f) hot add and remove a disk on LUN0~7
g) hot add and remove a disk on LUN0~6, LUN8
h) hot add and remove a disk on LUN1, 9, 10, 11, 12, 13, 14, 15
i) hot add and remove a disk on LUN0, 9, 10, 11, 12, 15, 18, 63
I didn't find any issue.
Sep 1 2017
Sep 1 2017
Aug 31 2017
Aug 31 2017
May 2 2017
May 2 2017
decui_microsoft.com abandoned D10531: add acpi_container.c to handle ACPI0004, PNP0A05, and PNP0A06.
Sephe will send out a patchset that will handle the issue in a better way.
Sephe will send out a patchset that will handle the issue in a better way.
decui_microsoft.com accepted D10564: pcicfg: Fix direct calls of pci_cfg{read,write} on system w/o PCI host bridge..
We need this patch to make PCIe pass-through work for Hyper-V UEFI VM (Generation 2 VM).
Apr 28 2017
Apr 28 2017
Apr 1 2017
Apr 1 2017
Mar 6 2017
Mar 6 2017
decui_microsoft.com retitled D9904: fix UEFI boot on physical machines from to fix UEFI boot on physical machines.
Feb 27 2017
Feb 27 2017
decui_microsoft.com added a comment to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
Cc'ed more people to have more input.
Feb 22 2017
Feb 22 2017
decui_microsoft.com updated the diff for D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
Fixed the typo: aviable -> available.
Feb 21 2017
Feb 21 2017
decui_microsoft.com added inline comments to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
decui_microsoft.com added inline comments to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
Feb 20 2017
Feb 20 2017
decui_microsoft.com added inline comments to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
decui_microsoft.com added a comment to D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
In D9686#200243, @marcel wrote:Going for the workaround I see! :-)
Yes, it's a workaround. Let's try to unblock Hyper-V for the usual case first: currently FreeBSD 10.3, 11, and the HEAD can't boot as UEFI VM on Hyper-V due to this bug.
decui_microsoft.com updated subscribers of D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
decui_microsoft.com retitled D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM) from to fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM).
Feb 15 2017
Feb 15 2017
decui_microsoft.com added a comment to D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx.
Thanks! No hurry. This is is only a trivial fix to improve error handling.
We don't have a strong dependency on it at all. Just to make sure I don't forget this patch. :-)
decui_microsoft.com added a comment to D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx.
@hselasky, can you please review this patch?
Feb 11 2017
Feb 11 2017
@hselasky, thank you!
decui_microsoft.com added a comment to D8867: net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs.
@hselasky, thanks Mellanox very much for reviewing and testing the patch!
Feb 10 2017
Feb 10 2017
decui_microsoft.com added a comment to D8867: net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs.
In D8867#196781, @hselasky wrote:Hi,
mlx4_core0: Failed to initialize event queue table (err=-12), aborting.
-12 means ENOMEM
I possibly means we're out of memory somehow. Can you track this down.
I assigned enough memory to the VM. :-)
Jan 26 2017
Jan 26 2017
decui_microsoft.com updated the diff for D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h.
fixed the comment typo pointed out by David.
decui_microsoft.com added inline comments to D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h.
decui_microsoft.com added inline comments to D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h.
decui_microsoft.com retitled D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h from ifnet: move the new ifnet_event EVENTHANDLER_DECLAREs to net/if_var.h to ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h.
decui_microsoft.com retitled D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h from to ifnet: move the new ifnet_event EVENTHANDLER_DECLAREs to net/if_var.h.
Jan 9 2017
Jan 9 2017
decui_microsoft.com retitled D9102: hyperv/hn: add devctl_notify for VF_UP/DOWN events from to hyperv/hn: add devctl_notify for VF_UP/DOWN events.
decui_microsoft.com retitled D9101: hyperv/hn: add a sysctl name for the VF interface from to hyperv/hn: add a sysctl name for the VF interface.
update the patches per Sephe's comments:
Jan 6 2017
Jan 6 2017
decui_microsoft.com updated the diff for D8963: ifnet: introduce event handlers for ifup/ifdown events.
Since sephe's patch (https://reviews.freebsd.org/D8905) is accepted, let me update this patch accordingly.
decui_microsoft.com updated the diff for D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx.
Let me update the patch, because the previous version causes a sysctl NULL pointer dereferencing issue: we must make sure mlx4_en_sysctl_stat() is called after mlx4_en_create_rx/tx_ring(), otherwise the stat sysctl nodes can't reference the correct ring pointers.
decui_microsoft.com added a comment to D8867: net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs.
Found a bug in MLX4 VF driver:
in my Hyper-V SR-IOV VF test with MlX ConnectX-3 VF, the VF works fine when the VM has <=12 virtual CPUs, but if the VM has >=13 vCPUs, the VF driver fails to load:
Dec 30 2016
Dec 30 2016
decui_microsoft.com added a comment to D8867: net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs.
In D8867#185655, @hselasky wrote:Hi,
The Mellanox FreeBSD team would like to review these changes before they hit the tree. I cannot say exactly when, but it might take a month or two.
--HPS
- Moved these bits to the end of hn_stop().
- Call hn_rxfilter_config() by force after the MTU changes.
- fixed a typo in Summary: "to to" -> "to".
This addressed all the comments.
Dec 29 2016
Dec 29 2016
decui_microsoft.com retitled D8964: hyperv/hn: add the support for VF drivers from to hyperv/hn: add the support for VF drivers.
decui_microsoft.com retitled D8963: ifnet: introduce event handlers for ifup/ifdown events from to ifnet: introduce event handlers for ifup/ifdown events.
decui_microsoft.com retitled D8962: hyperv/hn: remove the MTU and IFF_DRV_RUNNING checking in hn_rxpkt() from to hyperv/hn: remove the MTU and IFF_DRV_RUNNING checking in hn_rxpkt().
Dec 26 2016
Dec 26 2016
decui_microsoft.com updated the diff for D8909: hyperv/hn: remember the channel pointer in struct hn_rx_ring.
Moved the new field to the end of the struct.
decui_microsoft.com retitled D8909: hyperv/hn: remember the channel pointer in struct hn_rx_ring from to hyperv/hn: remember the channel pointer in struct hn_rx_ring.
Dec 21 2016
Dec 21 2016
decui_microsoft.com updated the diff for D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx.
addressed sephe's comment by using a better method: let's move mlx4_en_sysctl_stat() to an earlier place.
decui_microsoft.com retitled D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx from to mlx4_en_free_resources(): fix error handling for priv->stat_ctx.
Dec 20 2016
Dec 20 2016
decui_microsoft.com retitled D8868: net/mlx4: Change QP allocation scheme from to net/mlx4: Change QP allocation scheme.
decui_microsoft.com retitled D8867: net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs from to net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs.
Dec 14 2016
Dec 14 2016
In D8791#182029, @hselasky wrote:Looks good. Don't forget to MFC to 9/10 and 11. Note that the directory layout is different in 9/10/11 so you'll need to manually extract the patch and apply it. If you think this is difficult I can do the commit for you giving you the credit and handle the MFC-ing.
updated the patch.
decui_microsoft.com retitled D8791: Fix mlx4_pci_table's .driver_data from to linuxkpi: Fix the struct pci_device_id.
Nov 23 2016
Nov 23 2016
decui_microsoft.com added inline comments to D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
decui_microsoft.com updated the diff for D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
addressed jhb's comment
Nov 22 2016
Nov 22 2016
decui_microsoft.com updated the diff for D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Added a comment before the line "OLD_FILES+=usr/share/man/man4/hv_ata_pci_disengage.4.gz"
Nov 21 2016
Nov 21 2016
decui_microsoft.com updated the diff for D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
hv_ata_pci_disengage.4.gz doesn't exist for ALL architectures any longer.
decui_microsoft.com updated the diff for D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Don't forget usr/share/man/man4/hv_ata_pci_disengage.4.gz.
decui_microsoft.com updated the diff for D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
updated ObsoleteFiles.inc accordingly (removing the manuals for ARCHs other than amd64 and i386)
Nov 18 2016
Nov 18 2016
decui_microsoft.com retitled D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386 from to share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 10 2016
Nov 10 2016
decui_microsoft.com updated the diff for D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
Cleaned up some comments.
Ceaned up vmbus_pcib_detach() according to discussions with Hyper-V team.
Nov 3 2016
Nov 3 2016
decui_microsoft.com updated the diff for D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
This new version addressed jhb's comment: "use bus_read_4(hbus->cfg_res, xxx)".
decui_microsoft.com added a comment to D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
In D8332#175267, @jhb wrote:This is an interesting approach for pass through. The only other hypervisor I'm familiar with (bhyve) does the config space emulation in the hypervisor itself so that guests don't need modifications for pass through (they just show up as PCI devices).
decui_microsoft.com added inline comments to D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
decui_microsoft.com updated the diff for D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
This new version addressed jhb and sephe's comments.
decui_microsoft.com added a comment to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
In D8409#175368, @sepherosa_gmail.com wrote:In D8409#175275, @jhb wrote:This looks fine. Note that there is some existing code this somewhat duplicates. For example, the ACPI Host-PCI bridge driver also parses _CRS to determine valid ranges. It uses the pcib_host_res_* API to add those ranges to a list that it then iterates on allocation requests. I'm not sure if does the same trick of preferring > 4G ranges for 64-bit BARs (though if pcib_host_res_*() would otherwise work for you I'd be fine with fixing it to do the same).
Hmm, we probably can reuse the existing APIs, but do two pass decodes, the first pass adds the 64-bits BARs, the second one adds 32-bits BARs.
Good suggestion! I've made a patch with the 2-pass method. Will upload it shortly.
decui_microsoft.com added a comment to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Hi jhb, Thanks for the suggestion! I'll update the patch with the pcib_host_res_* APIs.
Nov 2 2016
Nov 2 2016
decui_microsoft.com added a comment to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
I uploaded the new version to address the comments.
decui_microsoft.com updated the diff for D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
This new version addressed Sephe's comments.
This new version addressed Sephe's comment.
Nov 1 2016
Nov 1 2016
decui_microsoft.com updated the diff for D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
The changes to VMBus were moved to 2 separate patches:
https://reviews.freebsd.org/D8410, and
https://reviews.freebsd.org/D8409
decui_microsoft.com updated the diff for D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
removed the get instance guid method, and moved the get_vcpu_id method to a separate patch (https://reviews.freebsd.org/D8410)
decui_microsoft.com added inline comments to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
decui_microsoft.com retitled D8410: hyperv/vmbus: add a new method to get vcpu_id from to hyperv/vmbus: add a new method to get vcpu_id.
decui_microsoft.com retitled D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through from to hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Oct 25 2016
Oct 25 2016
decui_microsoft.com retitled D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment) from to hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
Sep 29 2016
Sep 29 2016
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#167026, @hselasky wrote:Looks good. Do you have access to commit it?
decui_microsoft.com updated the diff for D8071: use a better method to get BAR type in pci_resource_flags().
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
Well, I managed to rebase my patch. Will upload it.
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#167006, @decui_microsoft.com wrote:In D8071#167001, @hselasky wrote:Can you also check that the new defines you use, like SYS_RES_IOPORT, are defined for all platforms, and not only i386 and amd64, because the LinuxKPI is building for all platforms.
Thanks for reminding me! I'll check this and rebase my patch later tomorrow -- sorry I can't do it right now, because it's late night here and I'll have to finish some family errands tomorrow first. :-)
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#167005, @hselasky wrote:Hi,
pci_request_region() was changed to use new function pci_resource_type() which returns the regular SYS_RES_XXX while pci_resource_flags() returns the shifted version.
I think it should be fine?
--HPS
Oh, I overlooked the patch.. sorry.
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#167001, @hselasky wrote:Can you also check that the new defines you use, like SYS_RES_IOPORT, are defined for all platforms, and not only i386 and amd64, because the LinuxKPI is building for all platforms.
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#167000, @hselasky wrote:Hi,
Please rebase your patch on top of:
https://svnweb.freebsd.org/changeset/base/306451Thank you!
--HPS
decui_microsoft.com added a comment to D8071: use a better method to get BAR type in pci_resource_flags().
In D8071#166966, @hselasky wrote:Hi,
There is a bug that we should return a bitmask from pci_resource_flags() and not a value.
We should return (1<<SYS_RES_IOPORT) etc and the corresponding Linux defines should be updated aswell!
--HPS
decui_microsoft.com retitled D8071: use a better method to get BAR type in pci_resource_flags() from to use a better method to get BAR type in pci_resource_flags().
Sep 23 2016
Sep 23 2016
Please review v2.
I moved the MEMEN/PORTEN clear/restore from pci_write_bar() to pci_reserve_map().
Sep 21 2016
Sep 21 2016