Differential D12175

hyperv/hn: Implement SIOCGIFRSS{KEY,HASH}.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 31 2017, 5:28 AM.

Tags

None

Referenced Files

	F135591953: D12175.id.diff
	Tue, Nov 11, 3:07 AM

	F135539968: D12175.diff
	Mon, Nov 10, 4:01 PM

	Unknown Object (File)
	Fri, Nov 7, 5:43 AM

	Unknown Object (File)
	Fri, Nov 7, 5:22 AM

	Unknown Object (File)
	Fri, Nov 7, 12:50 AM

	Unknown Object (File)
	Thu, Nov 6, 5:03 AM

	Unknown Object (File)
	Sat, Oct 25, 9:23 PM

	Unknown Object (File)
	Sat, Oct 25, 3:33 AM

View All 89 Files

Subscribers

None

Details

Reviewers

decui_microsoft.com
honzhan_microsoft.com
howard0su_gmail.com
royger
adrian
rwatson
glebius
gallatin

Commits

rS323175: hyperv/hn: Implement SIOCGIFRSS{KEY,HASH}.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com created this revision.Aug 31 2017, 5:28 AM

sepherosa_gmail.com added reviewers: adrian, rwatson, glebius, gallatin.Aug 31 2017, 5:32 AM

decui_microsoft.com added inline comments.Aug 31 2017, 5:49 AM

sys/dev/hyperv/netvsc/if_hn.c
3590 ↗	(On Diff #32536)	add HN_UNLOCK(sc) for "break"?
3623 ↗	(On Diff #32536)	ditto

sepherosa_gmail.com added inline comments.Aug 31 2017, 5:51 AM

sys/dev/hyperv/netvsc/if_hn.c
3590 ↗	(On Diff #32536)	Already unlocked.
3623 ↗	(On Diff #32536)	Unlocked.

gallatin accepted this revision.Aug 31 2017, 1:12 PM

This revision is now accepted and ready to land.Aug 31 2017, 1:12 PM

gallatin added inline comments.Aug 31 2017, 1:14 PM

sys/dev/hyperv/netvsc/if_hn.c
3319 ↗	(On Diff #32536)	Why the ifdefs?

sepherosa_gmail.com added inline comments.Sep 1 2017, 12:53 AM

sys/dev/hyperv/netvsc/if_hn.c
3319 ↗	(On Diff #32536)	I was not so sure whether I could MFC D12174 to 10-stable/11-stable or not, but I definitely want to MFC driver bits to 10-stable/11-stable. If D12174 goes well, I probably will MFC it to 10-stable/11-stable. I think adding IOCs does not break ABI.

decui_microsoft.com added inline comments.Sep 1 2017, 1:46 AM

sys/dev/hyperv/netvsc/if_hn.c
3590 ↗	(On Diff #32536)	You're correct. Sorry for the false alarm.

Closed by commit rS323175: hyperv/hn: Implement SIOCGIFRSS{KEY,HASH}. (authored by sephe). · Explain WhySep 5 2017, 6:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

netvsc/

52 lines

Diff 32666

head/sys/dev/hyperv/netvsc/if_hn.c

Loading...