• I've updated the code to follow the style as you mentioned.
• I've removed too wide CFLAGS from libsa Makefile.

As this was my first patch here I need to get familiar with the interface and the way how I can submit the changes. I also need to refresh my memory what I did as I did this in March.

In D34479#831843, @imp wrote:

Some general comments...

The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.

It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.

Some general comments...

LGTM

In D25373#565381, @greg_unrelenting.technology wrote:

In D25373#565380, @markm wrote:

ECAM hacks? When are those likely to appear? :-)

https://unrelentingtech.s3.dualstack.eu-west-1.amazonaws.com/flash-image-2020-07-01.bin try this image, it has the ECAM offset removed

@mw promised to make a toggle for ECAM offset in the setup menu.. :)

OK to close again.

That works, thanks! I'm at latest CURRENT, no backouts, my console works and so do my PCI ethernet port.

In D25373#565380, @markm wrote:

ECAM hacks? When are those likely to appear? :-)

ECAM hacks? When are those likely to appear? :-)

In D25373#565376, @markm wrote:

With this patch in, AND the flashe given above, I get my console back!

But I lose my PCI ethernet ports.

With this patch in, AND the flashe given above, I get my console back!

In D25373#565370, @markm wrote:

Worse. Previously working console now broken. Current with this change backed out now broken.

Is the console supposed to work without this fix applied?

Worse. Previously working console now broken. Current with this change backed out now broken.

Trying now. In the meanwhile, is there some place where the Collected Wisdom™ of all current mcbin firmware statusses, hints, binaries etc are kept?

Add conv=sync for dd
If it's the old version that GregV posted a while ago it's normal that this commit "breaks" for you, this image have a patched SPCR table to cope with the old bug that this code fixes.

Yup - my flash is a couple of months old, and a hand-rolled debug-version (not by me). The image you pointed to fails with checksum errors at boot, but it may have something to do with the way I made it. With the same MBR as the old one, I did:

It works fine on mine, are you using an old edk2 build maybe ?
Try https://people.freebsd.org/~manu/flash-image-mcbin.bin
This is mainline edk2 (latest stable version) and Marvell TF-A, ports will land soon.

This change breaks my MacchiattoBin DoubleShot. I've bisected to get to commit r362574, which is this. The symptoms are a hang right at the beginning of the boot, at this point:

@cperciva I'm adding such note, thanks.

Looks good to me. Might be worth mentioning in the commit message that EFI_ACPI_6_0_UNDEFINED handling is needed to work around a buggy SPCR table on EC2 x86 "bare metal" instances, just in case someone looks at the code a few years from now and wonders why we're doing this.

Works on my mcbin with the official SPCR table! :) Might test on other things later.

@cperciva @greg_unrelenting.technology Hi! Before I do the commit, I'm looking forward to your testing and I'd really appreciate your input.

Thanks for finding this. We went round and round when it went in. Might not hurt to make sure it still works on other boards
.

Thanks !
I've talked with Greg about this last week, glad you did it before me :)

Now calling from IOAPIC suspend/resume functions (if there's any better place "close to the nexus" I haven't found it.)

DMARs must be suspended after, and resumed before any subordinate devices. Because DMARs do not participate in the newbus hierarchy, or rather, they are placed there in the arbitrary place determined by not relevant details of the driver implementation, newbus suspend/resume methods are really not appropriate to use. The methods should be nops, and actual suspend/resume done near nexus.

More proper temp calculatuion based on RangeUnajusted, according to "Preliminary BIOS and Kernel Developer’s Guide (BKDG) for AMD Family 16h Models 00h-0Fh (Kabini) Processors".

I have not reviewed the entire driver because I ran into enough issues I want addressed first to warrant a highlevel comment first.

add Ryzen specific SMU registers.

Add support Bristol Ridge, possible Ryzen - need check
Remove TSI reading methods

I m waiting for documentation from AMD to Ryzen CPU, looks like 17h have new interfaces.

On

CPU: AMD Ryzen 7 1700X Eight-Core Processor          (3393.69-MHz K8-class CPU)

I get the following results:

sysctl dev.amdtemp

dev.amdtemp.0.rtc.sensor_offset: 0
dev.amdtemp.0.rtc.PerStepTimeUp: 0
dev.amdtemp.0.rtc.PerStepTimeDn: 0
dev.amdtemp.0.rtc.TmpMaxDiffUp: 0
dev.amdtemp.0.rtc.TmpSlewDnEn: 0
dev.amdtemp.0.rtc.CurTmpTjSel: -49.0C
dev.amdtemp.0.rtc.CurTmp: 0.1C
dev.amdtemp.0.%parent: hostb10
dev.amdtemp.0.%pnpinfo:
dev.amdtemp.0.%location:
dev.amdtemp.0.%driver: amdtemp
dev.amdtemp.0.%desc: AMD CPU On-Die Thermal Sensors
dev.amdtemp.%parent:

In D9759#204651, @cy wrote:

Will there be man page updates?

Since revision 310051 sysctl_add_oid have +1 param, add macro to handle it.

Will there be man page updates?

We can commit this once we get more testing done.

In D9759#204260, @rozhuk.im-gmail.com wrote:

I have some AMD: E350, 5350, APU 6800, Phenom II X4 955 - test OK.

I have some AMD: E350, 5350, APU 6800, Phenom II X4 955 - test OK.

How can we test this on all hardware versions? I don't have AMD hardware. You could ask on the mailing list.

Style update.
CTASSERT() removed.

I will fix style a bi later.

This needs a lot of style fixes. Please read the style man page and check other drivers for examples.

Style corrections.

At first, Thanks for your great work __/|\__
Technically I'm not right person to talk deeply about this.
But for helping to reduce amount of works for next reviewer (and also for you ;D),
Some style(9) points:
use the form:

type
name()
{
}

instead of

type
name() {
}