Forgot to add "Differential Revision" in commit message.
https://cgit.freebsd.org/ports/commit/?id=3f1b38acfda124fc8f03fe5f4edfef10ef214501
https://cgit.freebsd.org/ports/commit/?h=2023Q3&id=fc4ebc143c4b097ec1ea90fa6831a3125c8619de
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 19 2024
Dec 25 2023
Oct 22 2023
Oct 21 2023
Sep 18 2023
Sep 17 2023
Sep 2 2023
Jul 20 2023
Jul 16 2023
Jun 28 2023
That's a good cleanup, thanks!
Jun 26 2023
Update patch with git diff -U10000.
Jun 25 2023
(Some of these are comments because Phabricator seems to prevent suggestions for this review.)
Jun 24 2023
Tested build:
emulators/virtualbox-ose: poudriere and64 12.4, 13.1, 13.2; live 13.2.
emulators/virtualbox-ose-legacy: poudriere and64 and i386 12.4, 13.1, 13.2.
Jun 12 2023
I've been using this change since at least start of May 2022, so for more than one year, on about 5 points of 13-STABLE, including a very recent one, and with lots of virtual machines.
Did you conduct run-testing for this change?
Jun 11 2023
Jun 7 2023
Jun 6 2023
In D40408#920320, @vvd wrote:I understood you correctly?
Jun 5 2023
I understood you correctly?
could you please add explicit paranthesis in this part (${OSVERSION} < 1302505 || ${OSVERSION} >= 1400000 && ${OSVERSION} < 1400079)
Jun 3 2023
… Need last test: build with llvm15 from base and run on 14-CURRENT and 13-STABLE amd64 …
Jun 1 2023
May 30 2023
In D40254#917734, @grahamperrin wrote:https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming-revepoch – if I understand correctly, D40254 should bump the PORTREVISION from 1 to 2 at line 3.
Tested and works on a recent 14-CURRENT.
May 28 2023
https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.
May 26 2023
I will test on 14-CURRENT this weekend. The patch has been applied, packages built on my poudriere, and machines updated. I won't have time until Saturday or Sunday to test because the machine that will be used to run the test is busy with other work ATM.
May 25 2023
We have not found confirmation of the need for new patches.
In D40254#916487, @arrowd wrote:What's the rationale for patches? …
May 24 2023
What's the rationale for patches? They look strange.
May 23 2023
In D40163#915675, @vvd wrote:Can I commit this patch and begin to work on more important patch for fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189 ?
May 22 2023
Can I commit this patch and begin to work on more important patch for fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189 ?
Awesome, thanks!
May 21 2023
Replaced patch with: EXTRA_PATCHES+= ${.CURDIR}/../phpvirtualbox/files/patch-php8
In D40115#914945, @arrowd wrote:Are you sure this patch doesn't break anything for PHP < 8?
In D40163#914934, @rene wrote:In D40163#914757, @vvd wrote:In D40163#914756, @fuz wrote:See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.There are no 14.
That is what the "main" branch is, which will soon become stable/14 and 14.0
But indeed you will see all kinds of versions for 14000xx (and soon 15000xx) for "main"/ CURRENT.
I know version numbers in FreeBSD and about delayed release 14 too.
So before 14 released all > 1400000 "regarded" as supported.
Are you sure this patch doesn't break anything for PHP < 8?
In D40163#914757, @vvd wrote:In D40163#914756, @fuz wrote:See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.There are no 14.
May 20 2023
In D40116#914015, @arrowd wrote:Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?
Probably yes - diff is line numbers for 1 patch:
$ diff -ur www/phpvirtualbox/files/patch-php8 www/phpvirtualbox-legacy/files/patch-php8 --- www/phpvirtualbox/files/patch-php8 +++ www/phpvirtualbox-legacy/files/patch-php8 @@ -160,7 +160,7 @@ diff -ur panes/settingsDisplay.html.orig panes/settingsDisplay.html --- panes/settingsDisplay.html.orig +++ panes/settingsDisplay.html -@@ -77,9 +77,9 @@ +@@ -68,9 +68,9 @@ <th><span class='translate'>Authentication Method:</span></th> <td> <select name='vboxSettingsDisplayVRDEAuth' id='vboxSettingsDisplayVRDEAuthID' style='width: 100%'>
In D40163#914756, @fuz wrote:See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.
See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.
@rene what do you think about this?
In D40163#914751, @arrowd wrote:What's the point in fixing unsupported versions of 13 and 14?
What's the point in fixing unsupported versions of 13 and 14?
May 19 2023
LGTM
Renamed MANUAL to DOCS after discussion with Zirias in IRC.
May 18 2023
Great job!
Removed double REINPLACE_CMD for src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp - 1st is in patch.
After discussion in IRC did several improvements.
Replaced all "/usr/local" with %%LOCALBASE%% and "/usr/local/lib/virtualbox" with %%VBOX_DIR%%.