www/phpvirtualbox: PHP 8 support

[vvd]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261498

Using this patchset for more than 1 year on 4 hosts.

[arrowd]

www/phpvirtualbox/files/patch-php8

53

You introduce a new variable $allowed_exts but seemingly never change it. The count($allowed_exts) value would always be 0, no?

168

Is this hunk just a stylistic change? Remove it then.

184

Why remove 'Bridged'?

[vvd]

www/phpvirtualbox/files/patch-php8

53

It's "global" variable.
Value set outside "getdir" function endpoints/jqueryFileTree.php(66):

$allowed_exts = $settings->browserRestrictFiles;
if(is_array($allowed_exts) && count($allowed_exts) > 0) $allowed_exts = array_combine($allowed_exts,$allowed_exts);
else $allowed_exts = array();

168

1st line replace '' with 'Null' - don't thing it's just stylistic.
But other lines are formatting and I can remove these changes.

184

Look at comments before "if":

// Special case for Internal, Generic, and VDE network selects

List have 3 types except Bridged.

AFAIR, this is fix for some error, but I can't find comments to it and sources of this change.

[arrowd]

Are you sure this patch doesn't break anything for PHP < 8?

[vvd]

In D40115#914945, @arrowd wrote:

Are you sure this patch doesn't break anything for PHP < 8?

lang/php74|lang/php80|2022-12-25|Has expired: Security support ended on 2022-11-22
Isn't in ports for half of year.