emulators/virtualbox-ose[-legacy]: rename option MANUAL to DOCS and make it enabled by default
ClosedPublic
Actions

Authored by vvd on May 16 2023, 7:22 PM.

Details

Reviewers

grahamperrin
arrowd
tcberner
adamw

Group Reviewers

vbox

Commits

R11:a0ef5898beb4: emulators/virtualbox-ose[-legacy]: rename option MANUAL to DOCS and make it…

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266992

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vvd requested review of this revision.May 16 2023, 7:22 PM

vvd created this revision.

LGTM given that you did the build and then make check-plist.

This revision is now accepted and ready to land.May 18 2023, 6:58 AM

Renamed MANUAL to DOCS after discussion with Zirias in IRC.

Tested in poudriere on 12.4, 13.1 and 13.2.

This revision now requires review to proceed.May 19 2023, 11:52 AM

vvd retitled this revision from emulators/virtualbox-ose[-legacy]: make MANUAL enabled by default to emulators/virtualbox-ose[-legacy]: rename option MANUAL to DOCS and make it enabled by default.May 19 2023, 11:52 AM

tcberner added inline comments.May 19 2023, 11:57 AM

emulators/virtualbox-ose-legacy/Makefile
141	^ in a further review you could convert these to the `DOCS_...` syntax and get rid of all the ifs

vvd added inline comments.May 19 2023, 12:01 PM

emulators/virtualbox-ose-legacy/Makefile
141	Work in progress, but in another PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200764 I'll update patch https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189473&action=diff for current versions of the ports.