Page MenuHomeFreeBSD
Differential D42322

emulators/virtualbox-ose{,-kmod,-additions}: update to 6.1.48
ClosedPublic
Actions

Authored by vvd on Oct 21 2023, 10:19 PM.
Tags
Referenced Files
F113115685: D42322.id129212.diff
Wed, Mar 26, 2:31 PM
Unknown Object (File)
Fri, Feb 28, 1:19 PM
Unknown Object (File)
Feb 9 2025, 9:47 PM
Unknown Object (File)
Feb 4 2025, 6:57 PM
Unknown Object (File)
Feb 4 2025, 6:43 PM
Unknown Object (File)
Feb 4 2025, 1:42 PM
Unknown Object (File)
Jan 25 2025, 4:04 AM
Unknown Object (File)
Jan 15 2025, 2:11 AM
View All 74 Files
Subscribers
None

Details

Reviewers
arrowd
tcberner
adamw
Group Reviewers
vbox
Commits
R11:2852ece67577: emulators/virtualbox-ose{,-kmod,-additions}: update to 6.1.48
R11:ae6b467526ab: emulators/virtualbox-ose{,-kmod,-additions}: update to 6.1.48
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274555

Tested build in poudriere and on live system 13.2 amd64.
Tested run virtual machines.

Other users tested on 14.0.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
emulators/
virtualbox-ose-additions/
2 lines
6 lines
virtualbox-ose-kmod/
2 lines
6 lines
virtualbox-ose/
4 lines
10 lines

Diff 129212

View Options

emulators/virtualbox-ose-additions/Makefile

Show First 20 Lines • Show All 676 Lines • ▼ Show 20 Lines#define type_min(datatype) ( \
(sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \ (sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \
(sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \ (sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \
(sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \ (sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \
(is_signed(datatype) ? INT8_MIN : 0) \ (is_signed(datatype) ? INT8_MIN : 0) \
) )
#define TAINT_WARN 0 #define TAINT_WARN 0
#define test_taint(x) (0) #define test_taint(x) (0)
#define add_taint(x,y) do { \
bzUnsubmitted
Not Done
Inline Actions

I would have said do {} while (0).

bz: I would have said do {} while (0).
manuAuthorUnsubmitted
Done
Inline Actions

You've been suggesting this for a number of reviews, what's the point if you don't mind be asking ?

manu: You've been suggesting this for a number of reviews, what's the point if you don't mind be…
bzUnsubmitted
Not Done
Inline Actions

I believe most the ones I suggested are void functions, no return value; @hselasky in the past has always suggested to me for LinuxKPI to use do {} while(0) in those cases and that seems general style in FreeBSD.

Here's a quick test putting a (0); into an empty main function and you get a warning ...
I think we simply suppress them in the builds currently:

share/mk/bsd.sys.mk:CWARNFLAGS.clang+=  -Wno-tautological-compare -Wno-unused-value\
share/mk/bsd.sys.mk:            -Wno-error=unused-value
% cc -Wall 0.c -o 0-2
0.c:7:3: warning: expression result unused [-Wunused-value]
        (0);
         ^
1 warning generated.
bz: I believe most the ones I suggested are void functions, no return value; @hselasky in the past…
emasteUnsubmitted
Not Done
Inline Actions

Right, do { ... } while(0) is generally good practice so that it behaves similarly to a function with respect to cases like @bz mentions, the trailing ; after the macro behaves as expected, and (in the case of macros with actual bodies) it works properly inside of another block like if ... else ....

I think it's reasonable to just always put void function-like macros in do { } while (0)

emaste: Right, `do { ... } while(0)` is generally good practice so that it behaves similarly to a…
manuAuthorUnsubmitted
Done
Inline Actions

Thanks for the explanation, I'll update all the reviews to do this :)

manu: Thanks for the explanation, I'll update all the reviews to do this :)
} while (0)
static inline int static inline int
_h2b(const char c) _h2b(const char c)
{ {
if (c >= '0' && c <= '9') if (c >= '0' && c <= '9')
return (c - '0'); return (c - '0');
if (c >= 'a' && c <= 'f') if (c >= 'a' && c <= 'f')
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

emulators/virtualbox-ose-additions/distinfo

Show First 20 Lines • Show All 676 Lines • ▼ Show 20 Lines#define type_min(datatype) ( \
(sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \ (sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \
(sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \ (sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \
(sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \ (sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \
(is_signed(datatype) ? INT8_MIN : 0) \ (is_signed(datatype) ? INT8_MIN : 0) \
) )
#define TAINT_WARN 0 #define TAINT_WARN 0
#define test_taint(x) (0) #define test_taint(x) (0)
#define add_taint(x,y) do { \
bzUnsubmitted
Not Done
Inline Actions

I would have said do {} while (0).

bz: I would have said do {} while (0).
manuAuthorUnsubmitted
Done
Inline Actions

You've been suggesting this for a number of reviews, what's the point if you don't mind be asking ?

manu: You've been suggesting this for a number of reviews, what's the point if you don't mind be…
bzUnsubmitted
Not Done
Inline Actions

I believe most the ones I suggested are void functions, no return value; @hselasky in the past has always suggested to me for LinuxKPI to use do {} while(0) in those cases and that seems general style in FreeBSD.

Here's a quick test putting a (0); into an empty main function and you get a warning ...
I think we simply suppress them in the builds currently:

share/mk/bsd.sys.mk:CWARNFLAGS.clang+=  -Wno-tautological-compare -Wno-unused-value\
share/mk/bsd.sys.mk:            -Wno-error=unused-value
% cc -Wall 0.c -o 0-2
0.c:7:3: warning: expression result unused [-Wunused-value]
        (0);
         ^
1 warning generated.
bz: I believe most the ones I suggested are void functions, no return value; @hselasky in the past…
emasteUnsubmitted
Not Done
Inline Actions

Right, do { ... } while(0) is generally good practice so that it behaves similarly to a function with respect to cases like @bz mentions, the trailing ; after the macro behaves as expected, and (in the case of macros with actual bodies) it works properly inside of another block like if ... else ....

I think it's reasonable to just always put void function-like macros in do { } while (0)

emaste: Right, `do { ... } while(0)` is generally good practice so that it behaves similarly to a…
manuAuthorUnsubmitted
Done
Inline Actions

Thanks for the explanation, I'll update all the reviews to do this :)

manu: Thanks for the explanation, I'll update all the reviews to do this :)
} while (0)
static inline int static inline int
_h2b(const char c) _h2b(const char c)
{ {
if (c >= '0' && c <= '9') if (c >= '0' && c <= '9')
return (c - '0'); return (c - '0');
if (c >= 'a' && c <= 'f') if (c >= 'a' && c <= 'f')
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

emulators/virtualbox-ose-kmod/Makefile

Show First 20 Lines • Show All 676 Lines • ▼ Show 20 Lines#define type_min(datatype) ( \
(sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \ (sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \
(sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \ (sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \
(sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \ (sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \
(is_signed(datatype) ? INT8_MIN : 0) \ (is_signed(datatype) ? INT8_MIN : 0) \
) )
#define TAINT_WARN 0 #define TAINT_WARN 0
#define test_taint(x) (0) #define test_taint(x) (0)
#define add_taint(x,y) do { \
bzUnsubmitted
Not Done
Inline Actions

I would have said do {} while (0).

bz: I would have said do {} while (0).
manuAuthorUnsubmitted
Done
Inline Actions

You've been suggesting this for a number of reviews, what's the point if you don't mind be asking ?

manu: You've been suggesting this for a number of reviews, what's the point if you don't mind be…
bzUnsubmitted
Not Done
Inline Actions

I believe most the ones I suggested are void functions, no return value; @hselasky in the past has always suggested to me for LinuxKPI to use do {} while(0) in those cases and that seems general style in FreeBSD.

Here's a quick test putting a (0); into an empty main function and you get a warning ...
I think we simply suppress them in the builds currently:

share/mk/bsd.sys.mk:CWARNFLAGS.clang+=  -Wno-tautological-compare -Wno-unused-value\
share/mk/bsd.sys.mk:            -Wno-error=unused-value
% cc -Wall 0.c -o 0-2
0.c:7:3: warning: expression result unused [-Wunused-value]
        (0);
         ^
1 warning generated.
bz: I believe most the ones I suggested are void functions, no return value; @hselasky in the past…
emasteUnsubmitted
Not Done
Inline Actions

Right, do { ... } while(0) is generally good practice so that it behaves similarly to a function with respect to cases like @bz mentions, the trailing ; after the macro behaves as expected, and (in the case of macros with actual bodies) it works properly inside of another block like if ... else ....

I think it's reasonable to just always put void function-like macros in do { } while (0)

emaste: Right, `do { ... } while(0)` is generally good practice so that it behaves similarly to a…
manuAuthorUnsubmitted
Done
Inline Actions

Thanks for the explanation, I'll update all the reviews to do this :)

manu: Thanks for the explanation, I'll update all the reviews to do this :)
} while (0)
static inline int static inline int
_h2b(const char c) _h2b(const char c)
{ {
if (c >= '0' && c <= '9') if (c >= '0' && c <= '9')
return (c - '0'); return (c - '0');
if (c >= 'a' && c <= 'f') if (c >= 'a' && c <= 'f')
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

emulators/virtualbox-ose-kmod/distinfo

Show First 20 Lines • Show All 676 Lines • ▼ Show 20 Lines#define type_min(datatype) ( \
(sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \ (sizeof(datatype) >= 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \
(sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \ (sizeof(datatype) >= 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \
(sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \ (sizeof(datatype) >= 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \
(is_signed(datatype) ? INT8_MIN : 0) \ (is_signed(datatype) ? INT8_MIN : 0) \
) )
#define TAINT_WARN 0 #define TAINT_WARN 0
#define test_taint(x) (0) #define test_taint(x) (0)
#define add_taint(x,y) do { \
bzUnsubmitted
Not Done
Inline Actions

I would have said do {} while (0).

bz: I would have said do {} while (0).
manuAuthorUnsubmitted
Done
Inline Actions

You've been suggesting this for a number of reviews, what's the point if you don't mind be asking ?

manu: You've been suggesting this for a number of reviews, what's the point if you don't mind be…
bzUnsubmitted
Not Done
Inline Actions

I believe most the ones I suggested are void functions, no return value; @hselasky in the past has always suggested to me for LinuxKPI to use do {} while(0) in those cases and that seems general style in FreeBSD.

Here's a quick test putting a (0); into an empty main function and you get a warning ...
I think we simply suppress them in the builds currently:

share/mk/bsd.sys.mk:CWARNFLAGS.clang+=  -Wno-tautological-compare -Wno-unused-value\
share/mk/bsd.sys.mk:            -Wno-error=unused-value
% cc -Wall 0.c -o 0-2
0.c:7:3: warning: expression result unused [-Wunused-value]
        (0);
         ^
1 warning generated.
bz: I believe most the ones I suggested are void functions, no return value; @hselasky in the past…
emasteUnsubmitted
Not Done
Inline Actions

Right, do { ... } while(0) is generally good practice so that it behaves similarly to a function with respect to cases like @bz mentions, the trailing ; after the macro behaves as expected, and (in the case of macros with actual bodies) it works properly inside of another block like if ... else ....

I think it's reasonable to just always put void function-like macros in do { } while (0)

emaste: Right, `do { ... } while(0)` is generally good practice so that it behaves similarly to a…
manuAuthorUnsubmitted
Done
Inline Actions

Thanks for the explanation, I'll update all the reviews to do this :)

manu: Thanks for the explanation, I'll update all the reviews to do this :)
} while (0)
static inline int static inline int
_h2b(const char c) _h2b(const char c)
{ {
if (c >= '0' && c <= '9') if (c >= '0' && c <= '9')
return (c - '0'); return (c - '0');
if (c >= 'a' && c <= 'f') if (c >= 'a' && c <= 'f')
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

emulators/virtualbox-ose/Makefile

Loading...
View Options

emulators/virtualbox-ose/distinfo

Loading...