emulators/virtualbox-ose{,-legacy}: sort out options

[vvd]

Summary

Sort out options: order (portlint), convert to OPTION_*: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200764
Added entry in "Troubleshooting" about "VERR_NO_MEMORY": https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252227
Force devel/llvm15 for emulators/virtualbox-ose-legacy on recent 14 with llvm16 in base.

Tested build in poudriere.
And on live system 13.2 amd64 build and run both ports.

[vvd]

Tested build:
emulators/virtualbox-ose: poudriere and64 12.4, 13.1, 13.2; live 13.2.
emulators/virtualbox-ose-legacy: poudriere and64 and i386 12.4, 13.1, 13.2.

[grahamperrin]

emulators/virtualbox-ose-legacy/pkg-message

86

Change to:

the wiki

87

Change to:

https

[grahamperrin]

(Some of these are comments because Phabricator seems to prevent suggestions for this review.)

emulators/virtualbox-ose-legacy/pkg-message

74

https://bugs.freebsd.org/252227

emulators/virtualbox-ose/files/pkg-message.in

74

https://bugs.freebsd.org/252227

88

(https://bugs.freebsd.org/259399)

[arrowd]

emulators/virtualbox-ose-legacy/Makefile

157

I think it won't hurt to define these vars unconditionally.

162

Same here.

[vvd]

emulators/virtualbox-ose-legacy/Makefile

157

It won't break the following lines if DOCS off?

post-patch:
…
        @${ECHO_CMD} 'VBOX_PATH_DOCBOOK = ${DBKXSLDIR}' >> \
            ${WRKSRC}/LocalConfig.kmk
        @${ECHO_CMD} 'VBOX_PATH_DOCBOOK_DTD = ${DBKXMLDIR}' >> \
            ${WRKSRC}/LocalConfig.kmk

162

Nothing broken anywhere?

[vvd]

Update patch with git diff -U10000.

[arrowd]

emulators/virtualbox-ose-legacy/Makefile

157

Hmmm, who knows. Then to be on the safe side:

DOCS_VARS= vbox_path_docbook=${DBKXSLDIR}

See https://docs.freebsd.org/en/books/porters-handbook/book/#options-vars

[vvd]

emulators/virtualbox-ose-legacy/Makefile

157

Do this trick work for:

PYDISTUTILS_PKGNAME=    vboxapi
PYDISTUTILS_PKGVERSION= 1.0

too?

PYTHON_VARS=            pydistutils_pkgname=vboxapi pydistutils_pkgversion=1.0

[arrowd]

emulators/virtualbox-ose-legacy/Makefile

157

Yep it should.

[arrowd]

That's a good cleanup, thanks!