www/phpvirtualbox-legacy: PHP 8 support

[vvd]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261498

Patches are same for both www/phpvirtualbox and www/phpvirtualbox-legacy.

[arrowd]

Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?

[vvd]

In D40116#914015, @arrowd wrote:

Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?

Probably yes - diff is line numbers for 1 patch:

$ diff -ur www/phpvirtualbox/files/patch-php8 www/phpvirtualbox-legacy/files/patch-php8 
--- www/phpvirtualbox/files/patch-php8
+++ www/phpvirtualbox-legacy/files/patch-php8
@@ -160,7 +160,7 @@
 diff -ur panes/settingsDisplay.html.orig panes/settingsDisplay.html
 --- panes/settingsDisplay.html.orig
 +++ panes/settingsDisplay.html
-@@ -77,9 +77,9 @@
+@@ -68,9 +68,9 @@
                <th><span class='translate'>Authentication Method:</span></th>
                <td>
               <select name='vboxSettingsDisplayVRDEAuth' id='vboxSettingsDisplayVRDEAuthID' style='width: 100%'>

[vvd]

Replaced patch with: EXTRA_PATCHES+= ${.CURDIR}/../phpvirtualbox/files/patch-php8

Tested in poudriere 12.4, 13.1 and 13.2.

[arrowd]

Awesome, thanks!