www/phpvirtualbox-legacy: PHP 8 support
ClosedPublic
Actions

Authored by vvd on May 16 2023, 12:51 PM.

Details

Reviewers

arrowd
tcberner
adamw

Group Reviewers

vbox

Commits

R11:c94e0944b7f5: www/phpvirtualbox-legacy: PHP 8 support
R11:f3629be7b94f: www/phpvirtualbox-legacy: PHP 8 support

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261498

Patches are same for both www/phpvirtualbox and www/phpvirtualbox-legacy.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vvd requested review of this revision.May 16 2023, 12:51 PM

vvd created this revision.

Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?

In D40116#914015, @arrowd wrote:

Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?

Probably yes - diff is line numbers for 1 patch:

$ diff -ur www/phpvirtualbox/files/patch-php8 www/phpvirtualbox-legacy/files/patch-php8 
--- www/phpvirtualbox/files/patch-php8
+++ www/phpvirtualbox-legacy/files/patch-php8
@@ -160,7 +160,7 @@
 diff -ur panes/settingsDisplay.html.orig panes/settingsDisplay.html
 --- panes/settingsDisplay.html.orig
 +++ panes/settingsDisplay.html
-@@ -77,9 +77,9 @@
+@@ -68,9 +68,9 @@
                <th><span class='translate'>Authentication Method:</span></th>
                <td>
               <select name='vboxSettingsDisplayVRDEAuth' id='vboxSettingsDisplayVRDEAuthID' style='width: 100%'>