I just applied the patch and tried to compile one port:

poudriere testport -p gitlab -j 131amd64 devel/rubygem-gitlab-labkit

Run Tools/scripts/indent_make_if.pl on ruby.mk file.

This looks good to me.

This includes the entire BIG patch to convert bsd.octave.mk to Mk/Uses/octave.mk including the updates requested by @tcberner

I think as this replaces bsd.octave.mk, I would push it and the conversion of the tree in one big commit.

• Remove CXXFLAGS=-std-gnu++11
• Remove editorconfigs

In D37887#860795, @diizzy wrote:

Is it intentional that we request c++14 support but set gnu++11 in CXXFLAGS?

Nah prehistoric garbage.

Is it intentional that we request c++14 support but set gnu++11 in CXXFLAGS?
L1 and L2 should be removed and replaced with a short description instead?

Abandoning as I lack mental energy to respond to possible comments, and I'm probably no longer interested in FreeBSD.
This has nothing to do with this review, this is just accumulated. Feel free to pickup the revision if you are interested.

An improved version has been committed to ports, thanks!

Phrasing by Daniel O'Connor.

In D25433#562495, @pstef wrote:

In D25433#562475, @0mp wrote:

Just a note for your consideration: I wonder if we should mention there, that people often use set SU_CMD to use sudo (I do at least):

.if exists(/usr/local/bin/sudo)
SU_CMD= /usr/local/bin/sudo -E sh -c
.endif

As we all know, sudo is a port itself and not necessary to utilize SU_CMD (as portmaster.8 seems to claim, the way I read it). I'd omit sudo from ports.7 entirely on the basis that it doesn't have any advantage over su(1), but that would be incorrect - it's at least more convenient to not have to type in the password all the time. I could mention it here, but I think there are not too many people who use su(1) on a daily basis and not know about sudo. If they know, they will easily decide whether to use su or sudo.

In D25433#562475, @0mp wrote:

Just a note for your consideration: I wonder if we should mention there, that people often use set SU_CMD to use sudo (I do at least):

.if exists(/usr/local/bin/sudo)
SU_CMD= /usr/local/bin/sudo -E sh -c
.endif

In D25433#562467, @debdrup wrote:

I'm not completely sure about .It Va, but the Va macro is not documented in mandoc(7) and only appears in some openbsd mandoc.samples man-page which doesn't seem to be connected to their or our build, where it's referenced as a variable.
.Ql also isn't documented in mandoc(7), however it's a quoted literal according to groff_mdoc(7) from textproc/groff, so I think it's fine.

You also need to attach an actual reviewer, as I'm just a stand-in. ;)

Well, an actual doc persons opinion is more valuable than mine, so I defer :)

What I did is I think consistent with the rest of the file, for example

.It Cm fetch
Fetch all of the files needed to build this port from the sites
listed in
.Va MASTER_SITES
and
.Va PATCH_SITES .
See
.Va FETCH_CMD , MASTER_SITE_OVERRIDE
and
.Va MASTER_SITE_BACKUP .

Just a note for your consideration: I wonder if we should mention there, that people often use set SU_CMD to use sudo (I do at least):

I'm not completely sure about .It Va, but the Va macro is not documented in mandoc(7) and only appears in some openbsd mandoc.samples man-page which doesn't seem to be connected to their or our build, where it's referenced as a variable.
.Ql also isn't documented in mandoc(7), however it's a quoted literal according to groff_mdoc(7) from textproc/groff, so I think it's fine.

Closing this due to timeout

Akin to what is done for Emacs, Python, or PHP, the flavors for server side Postgresql extensions need to be handled by USES=pgsql, not in each individual port.

In D19662#422963, @mat wrote:

No, this should be done by USES=pgsql.

No, this should be done by USES=pgsql.

Abandoning this change (probably not applicable to enough ports).

• Remove FLAVOR support. QT4 will be deprecated soon. it'll use QT instead of

• Update to 1.64.0

• Update to 2.1.4
• Some minor changes

• Update to 1.60.0
• Update dependencies

• Update to 2.1.3
• Add DISTVERSIONPREFIX
• Add CONFLICTS

• Move flavors helpers to right place

• Add missing items to flavor_CONFLICTS

• Apply mat's suggestions

• Apply mat's suggestions

• Apply mat's suggestions

• Apply mat's suggestions

• Apply mat's suggestions

not adding FLAVORS, remove portmgr.

Does not need portmgr approval, not adding FLAVORS.

Does not add FLAVORS, no need for portmgr approval.

• Migrate to new QT helpers

• Add WRKSRC line

• Apply mat's suggestions

• Apply mat's suggestions

• Apply mat's suggestions

• Apply mat's suggestions

• Apply changes accord to mat commentaries

The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.

The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.

The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.

The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.

• Update patch file with right version