The full list of arches is here: https://www.freebsd.org/platforms/
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Fri, Mar 22
Thu, Mar 21
ping again
Wed, Mar 20
Tue, Mar 19
Update diff with more context
Can you re-upload the diff with arcanist or by generating the diff with more context, like arcanist does (git diff -U9999)
Mon, Mar 18
LGTM, but I didn't run-test this, as I don't use overlays.
Sat, Mar 16
ping
Thu, Mar 7
Not sure why but somehow I believe I failed to add this as the review in my commit message. This has already landed.
Tue, Mar 5
The new var should be names OPTIONS_DEFAULT_OTHER_ARCHS, without "E", to follow ONLY_FOR_ARCHS.
Thu, Feb 29
LGTM.
Feb 7 2024
Already committed.
Dec 31 2023
In D42068#985819, @rene wrote:In D42068#985744, @jbeich wrote:Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
This cleanup only affects main, not quarterly/2023Q4. There is a 12-eol tag on main so the pkg builders could stick to that?
On a different note jbeich is somewhat correct. If the builders were still started it would end up with an empty pkgset and the cluster pkgset would overwrite the pkg repos with an empty set being served. Although not exactly sure on how the builders are run so we disabled the pkgsync script and backed it up and have removed the pkgsets.
In D42068#985744, @jbeich wrote:Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
Dec 30 2023
In D42068#985549, @jbeich wrote:Many patches for missing <byteswap.h> and <endian.h> on FreeBSD < 13 can probably be dropped e.g.,
Many patches for missing <byteswap.h> and <endian.h> on FreeBSD < 13 can probably be dropped e.g.,
- audio/bespokesynth/files/patch-libs_link_include_ableton_platforms_linux_Linux.hpp
- audio/mixxx/files/patch-lib_kaitai_kaitaistream.cpp
- audio/umurmur/Makefile (BROKEN_*)
- audio/umurmur/files/patch-src_byteorder.h
- audio/webrtc-audio-processing/files/patch-powerpc64 (keep <altivec.h> part)
- audio/zita-alsa-pcmi/files/patch-source_zita-alsa-pcmi.cc
- biology/abyss/files/patch-Common_city.cc
- databases/redisdesktopmanager/files/patch-3rdparty_simdjson_singleheader_simdjson.h
- devel/chrpath/files/patch-protos.h (keep Elf_Ehdr part)
- devel/cityhash/files/patch-src_city.cc
- devel/dwarves/files/patch-lib_bpf_src_btf.c (the first 3 hunks, keep from compare_vsi_off onwards)
- devel/efivar/files/patch-src-efivar.h (keep __builtin_* part)
- devel/elfutils/files/patch-lib_byteswap.h
- devel/firmware-utils/files/patch-* (<endian.h> part, keep `"freebsd.h")
- devel/py-pysimdjson/files/patch-simdjson_simdjson.h
- graphics/igt-gpu-tools/files/patch-lib_igt_\_core.h (keep <signal.h> part)
- graphics/libemf/files/patch-libemf_libemf.cpp
- multimedia/dvb-apps/files/patch-lib_libucsi_endianops.h
- multimedia/ringrtc/files/patch-src_webrtc_src_rtc_\_base_byte_\_order.h
- multimedia/smpeg/files/patch-video_\_video.h
- net/mercury/Makefile (BROKEN)
- net/yate/files/patch-libs_yradio_radio.cpp
- security/pam_pwdfile/files/patch-md5.c
- sysutils/afflib/files/patch-lib_qemu_bswap.h
- sysutils/dd_rescue/files/patch-aes_\_c.c
- sysutils/lttng-tools/files/patch-src_bin_lttng-crash_lttng-crash.c
- sysutils/lttng-tools/files/patch-src_common_compat_endian.h
- sysutils/zbackup/files/patch-compression.cc
- sysutils/zbackup/files/patch-endian.hh
- www/envoy/files/patch-envoy_common_platform.h (keep ENVOY_MMSG_MORE part)
- www/mod_gnutls/files/patch-src_gnutls_\_sni.c
- www/qt5-webengine/files/patch-src_3rdparty_chromium_third_\_party_smhasher_src_City.cpp
Dec 23 2023
Latest rebase and most probably the last one before the sunset.
Dec 13 2023
Dec 12 2023
More changes by @jbeich
In D42068#980655, @jbeich wrote:In D42068#980602, @bofh wrote:These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
aarch64 (arm64) has 2 "a" in the architecture name. sparc64 (64-bit sparc, or sparc V9) may not define __sparc64__ on non-BSDs thus required checking both __sparc__ and __arch64__.
Add more changes by @jbeich
In D42068#980602, @bofh wrote:These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
In D42068#980467, @jbeich wrote:
- shells/v7sh/files/Makefile (only ${OSREL:R} < 13)
- www/tor-browser/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
Update as per @jhale
Dec 11 2023
Missed cruft (based on 2023-12-11 checkout):
- lang/emilua/Makefile (only IGNORE_FreeBSD_12)
- lang/go-devel/Makefile (only ${OSREL:R} < 13)
- lang/mlton/Makefile (keep ${OSREL:R} >= 13 but make unconditional)
- mail/fetchmail/Makefile (only ${OSREL:R} < 13)
- net/widentd/Makefile (only ${OSREL:R} < 13)
- shells/v7sh/files/Makefile (only ${OSREL:R} < 13)
- sysutils/plasma5-powerdevil/files/patch-daemon_backends_upower_freebsdbacklighthelper.cpp
- www/tor-browser/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
Rebase and add some changes as per @jbeich
Thanks @jbeich . I will look into it and refresh the patch.
Missed cruft (based on 2023-10-14 checkout):
- audio/opus/Makefile (only arm conditional)
- cad/nvc/Makefile (only !exists(/usr/include/unwind.h) conditional)
- comms/ebusd/files/patch-src_lib_ebus_datatype.cpp
- devel/android-tools/files/patch-vendor_adb_compression_\_utils.h
- devel/llvm1[2-3]/Makefile (only unwind.h-related _BUILD_DEPENDS, _USES, inline comments)
- emulators/rpcs3/files/patch-libc++13
- graphics/darktable/Makefile (only ${OPSYS}_${OSREL:R} == FreeBSD_12 conditional)
- graphics/krita/files/patch-cmake_modules_xsimd_xsimdMacros.cmake
- graphics/qt5-wayland/files/patch-src_client_qwaylandshmbackingstore.cpp (only && __FreeBSD_version >= 1300048 part)
- java/openjdk*/Makefile (only ${OSREL:C/\.[0-9]//} == 12 conditional and the related patch)
- mail/thunderbird/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
- multimedia/dav1d/files/patch-freebsd12
- multimedia/pipewire/files/patch-src_modules_module-netjack2_peer.c
- net-im/libquotient/files/patch-Quotient_qt_\_connection_\_util.h
- net/samba413/Makefile (only ${OSVERSION} < 1300000 conditional)
- sysutils/arcconf/Makefile (only ${OSREL:R} == 12 part)
- www/chromium/files/patch-third_\_party_wayland_include_config.h (only memfd part)
- www/chromium/files/patch-ui_ozone_platform_wayland_host_zwp_\_text_\_input_\_wrapper_\_v1.cc
- Ditto (as www/chromium) in devel/electron*, www/iridium, www/ungoogled-chromium
- www/librewolf/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
- x11/xdg-desktop-portal-luminous/Makefile (only BROKEN_FreeBSD_12)
Dec 6 2023
BROKEN_FreeBSD12 in www/ladybird can be removed too
Nov 11 2023
Nov 1 2023
https://cgit.FreeBSD.org/ports/commit/?id=0815295e0b7988daf05dc1665b4ff523c7083763 can be reverted too as part of this change
Oct 29 2023
Oct 19 2023
Oct 15 2023
Update some of the files based on the review from @rene
www/firefox/files/patch-third__party_libwebrtc_rtc__base_ip__address.cc
and
www/firefox-esr/files/patch-third__party_libwebrtc_rtc__base_ip__address.cc
are also obsolete after 12-EOL
Oct 5 2023
Changes are fine as such for devel/llvm* although devel/llvm17 is missing the Sparc backend removal. I think it's OK to not bump port revision here as the FreeBSD backends are a non-default configuration.
In D42068#960015, @salvadore wrote:In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273397 I have requested an exp-run that found errors that seem to apply to FreeBSD 12 only. Do you suggest that I request a new exp-run on FreeBSD 13 and ignore all FreeBSD 12 specific issues? And maybe also wait for FreeBSD 12 official EOL to commit the final patch?
Do you have a plan to merge this into quarterly? If not then I would say forget 12 related patches in your fixes. Additionally I saw your patch and some of the fallouts. I forgot the bug which you assigned to me but so far I found that the fallout reasons are due to an issue with GCC13 which was fixed in the most recent version of GCC13.
I approve as far as the ports that I maintain (GCC ports from 10 to 14) are concerned.
Oct 4 2023
May 17 2023
Looks good, thanks for making the changes.
Apr 11 2023
Apr 6 2023
Apr 5 2023
Mar 22 2023
Feb 3 2023
Why www/redmine42 was converted to USES= ruby but redmine50 not?
Many ports don't have USE_RUBY or USES=ruby anymore, I fail to understand the logic.
Feb 2 2023
Already landed in the tree.
Jan 25 2023
looks sane to me
Jan 19 2023
In D38113#865828, @tcberner wrote:ah, no conversion of bsd.apache.mk to apache.mk, ignore my previous comment here :D
ah, no conversion of bsd.apache.mk to apache.mk, ignore my previous comment here :D
Jan 18 2023
Jan 11 2023
Have you deleted the line USE_RUBY=yes from the Makefile of the port?
not yet, I would like to see the sanity check to fail.
Without removing USE_RUBY I see the following error message, is this intended:poudriere testport -p gitlab -j 131amd64 devel/rubygem-gitlab-labkit [00:00:00] Creating the reference jail... done [00:00:00] Mounting system devices for 131amd64-gitlab [00:00:00] Warning: Using packages from previously failed, or uncommitted, build: /usr/local/poudriere/data/packages/131amd64-gitlab/.building [00:00:00] Mounting ccache from: /var/cache/ccache [00:00:00] Mounting ports from: /usr/local/poudriere/ports/gitlab [00:00:00] Mounting packages from: /usr/local/poudriere/data/packages/131amd64-gitlab [00:00:00] Mounting distfiles from: /usr/local/poudriere/ports/gitlab/distfiles [00:00:00] Copying /var/db/ports from: /usr/local/etc/poudriere.d/options [00:00:00] Appending to make.conf: /usr/local/etc/poudriere.d/make.conf /etc/resolv.conf -> /usr/local/poudriere/data/.m/131amd64-gitlab/ref/etc/resolv.conf [00:00:00] Starting jail 131amd64-gitlab [00:00:00] Will build as nobody:nobody (65534:65534) [00:00:01] Ports supports: FLAVORS SELECTED_OPTIONS [00:00:01] Logs: /usr/local/poudriere/data/logs/bulk/131amd64-gitlab/2023-01-11_16h49m01s [00:00:01] WWW: https://pkg.fechner.net//build.html?mastername=131amd64-gitlab&build=2023-01-11_16h49m01s [00:00:01] Loading MOVED for /usr/local/poudriere/data/.m/131amd64-gitlab/ref/usr/ports [00:00:01] Gathering ports metadata [00:00:01] Warning: (lang/ruby30): make: "/usr/ports/lang/ruby30/Makefile" line 107: Malformed conditional (${RUBY_VER} == ${RUBY_DEFAULT_VER}) [00:00:01] Warning: (lang/ruby30): make: "/usr/ports/lang/ruby30/Makefile" line 162: Malformed conditional (${RUBY_VER} == ${RUBY_DEFAULT_VER}) [00:00:01] Warning: (lang/ruby30): make: Fatal errors encountered -- cannot continue [00:00:01] Warning: (lang/ruby30): Error: Error looking up dependencies for lang/ruby30 [00:00:01] Error: Fatal errors encountered gathering ports metadata [131amd64-gitlab] [2023-01-11_16h49m01s] [crashed:] Queued: 0 Built: 0 Failed: 0 Skipped: 0 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 00:00:01
I have shared the full patch(still WIP) here https://people.freebsd.org/~bofh/dropzone/ruby.diff
In D37925#863641, @bofh wrote:I don't know how you have applied the patch but just for the sake of your message I have retried applying the patch on a freshly brewed ports tree like the following:
cd ports git apply ~/Downloads/ruby.diff
In D37925#863633, @mfechner wrote:I just applied the patch and tried to compile one port: