As we are approaching a stage when we can no longer allow installing manpages in ${PREFIX}/man so add proper qa for checking this. For now this is a warn and once we move all ports into ${PREFIX}/share/man we will convert this into err. Or we can even do this now.
Details
Details
I have just built a port which has not ben converted and this is the result:
https://pkg.bofh.network/data/132-default/2024-02-29_14h28m20s/logs/nmsg-1.1.2.log
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
LGTM.
| Mk/Scripts/qa.sh | ||
|---|---|---|
| 1041 | find seems to return 0 when nothing is found and 1 otherwise. Maybe it is better to check an exit code there? | |
| Mk/Scripts/qa.sh | ||
|---|---|---|
| 1041 | That is another way of doing that indeed but with that we cannot list the files which are problematic. So if we want to go for a warning only without the file lists we can do that way. Either way is good for me. So the question is should we print the list of problematic files or not? | |
| Mk/Scripts/qa.sh | ||
|---|---|---|
| 1041 |
I think yes, certainly. | |
| Mk/Scripts/qa.sh | ||
|---|---|---|
| 1041 | Then we cannot go for the exit code method. That is good when we just want a binary check. | |
Comment Actions
Not sure why but somehow I believe I failed to add this as the review in my commit message. This has already landed.