Page MenuHomeFreeBSD

New port: editors/cudatext: Cross-platform text editor, written in Lazarus
AbandonedPublic

Authored by acm on Apr 30 2018, 2:50 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

acm created this revision.Apr 30 2018, 2:50 PM
acm edited the summary of this revision. (Show Details)Apr 30 2018, 2:56 PM
acm added a comment.Jun 5 2018, 9:48 PM

any news about it?

mat added inline comments.Jun 6 2018, 10:40 AM
cudatext/Makefile
46

Remove, set GH_PROJECT=CudaText instead. Isn't there a warning about this exact thing?

mat added a comment.Jun 6 2018, 10:42 AM

The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.

linimon retitled this revision from New port: editors/cudatext to New port: editors/cudatext: Cross-platform text editor, written in Lazarus.Aug 2 2018, 10:13 PM
acm updated this revision to Diff 46241.Aug 3 2018, 3:43 PM
  • Apply mat's suggestions
mat added inline comments.Aug 6 2018, 9:14 AM
Makefile
43 ↗(On Diff #46241)

Like the warning told you, please remove this line, it is wrong.

45 ↗(On Diff #46241)

The flavors are framework generated, you cannot know which will be the default, it would be better to use variables instead of a condition, like:

USE_FPC_gtk2=  cairo
USE_GNOME_gtk2= cairo
USE_FPC+= ${USE_FPC_${FLAVOR}}
USE_GNOME+= ${USE_GNOME_${FLAVOR}}
acm updated this revision to Diff 46349.Aug 6 2018, 6:42 PM
  • Apply mat's suggestions
acm marked 2 inline comments as done.Aug 6 2018, 6:42 PM
mat added inline comments.Aug 7 2018, 7:10 AM
Makefile
33–35 ↗(On Diff #46349)

Wrong place in the Makefile. These are flavors helpers. See Chapter 15. Order of Variables in Port Makefiles.

acm updated this revision to Diff 46374.Aug 7 2018, 7:43 AM
  • Move flavors helpers to right place
acm marked an inline comment as done.Aug 7 2018, 7:43 AM
acm updated this revision to Diff 47474.Aug 30 2018, 5:46 AM
  • Update to 1.60.0
  • Update dependencies
acm updated this revision to Diff 49542.Oct 24 2018, 6:04 AM
  • Update to 1.64.0
acm abandoned this revision.Mar 7 2019, 6:36 AM