Page MenuHomeFreeBSD

New port: editors/cudatext: Cross-platform text editor, written in Lazarus
AbandonedPublic

Authored by acm on Apr 30 2018, 2:50 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

cudatext/Makefile
45

Remove, set GH_PROJECT=CudaText instead. Isn't there a warning about this exact thing?

linimon retitled this revision from New port: editors/cudatext to New port: editors/cudatext: Cross-platform text editor, written in Lazarus.Aug 2 2018, 10:13 PM
  • Apply mat's suggestions
Makefile
43 ↗(On Diff #46241)

Like the warning told you, please remove this line, it is wrong.

45 ↗(On Diff #46241)

The flavors are framework generated, you cannot know which will be the default, it would be better to use variables instead of a condition, like:

USE_FPC_gtk2=  cairo
USE_GNOME_gtk2= cairo
USE_FPC+= ${USE_FPC_${FLAVOR}}
USE_GNOME+= ${USE_GNOME_${FLAVOR}}
  • Apply mat's suggestions
acm marked 2 inline comments as done.Aug 6 2018, 6:42 PM
Makefile
33–35 ↗(On Diff #46349)

Wrong place in the Makefile. These are flavors helpers. See Chapter 15. Order of Variables in Port Makefiles.

  • Move flavors helpers to right place
acm marked an inline comment as done.Aug 7 2018, 7:43 AM
  • Update to 1.60.0
  • Update dependencies