Page MenuHomeFreeBSD

audio/mixxx update to 2.1.4
AbandonedPublic

Authored by acm on Apr 24 2018, 4:07 AM.

Details

Reviewers
None
Group Reviewers
portmgr
Summary
  • Add qt4|qt5 FLAVORS
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mixxx/Makefile
1

The only case where you can remove this line is if the person in it asked you to. In all other cases, it is write-only.

7

The distribution file name is too generic, please use DIST_SUBDIR.

36

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

36–38

Wrong place in the Makefile.

39

Wrong place in the Makefile.

40–52

Wrong place in the Makefile.

70–73

Wrong place in the Makefile.

acm marked 7 inline comments as done.
  • Apply changes according mat commentaries
Makefile
7–9 ↗(On Diff #43008)

Sorry, missed the fact that you were not using USE_GITHUB like you should, here, add:

DISTVERSIONPREFIX=release-

and later, add:

USE_GITHUB=yes
GH_ACCOUNT=mixxxdj
47 ↗(On Diff #43008)

Remove.

75–81 ↗(On Diff #43008)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm marked 3 inline comments as done.
  • Apply changes according mat commentaries
  • Update patch file with right version
mixxx/Makefile
5–6

You should probably be using DISTVERSION.

7–8

Not required, could be removed.

34–36

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

96–109

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm retitled this revision from audio/mixxx update to 2.1.0 to audio/mixxx update to 2.1.1.Aug 3 2018, 3:07 PM
  • Apply changes accord to mat commentaries
  • Migrate to new QT helpers
Makefile
33 ↗(On Diff #46254)

You should probably help to set FLAVOR here, you could drop all :U* dances later, see https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html

45 ↗(On Diff #46254)

Default, please remove.

  • Apply mat's suggestions
acm marked 2 inline comments as done.Aug 6 2018, 6:44 PM
Makefile
36–37 ↗(On Diff #46351)

Not exactly sure why using flavors helpers for this, it is the same value for both.

  • Add missing items to flavor_CONFLICTS
acm marked an inline comment as done.Aug 7 2018, 7:24 AM
acm marked 2 inline comments as done.
acm marked 2 inline comments as done.
mixxx/Makefile
44

There is a release-2.1.1 you can use:

DISTVERSIONPREFIX=  release-
acm retitled this revision from audio/mixxx update to 2.1.1 to audio/mixxx update to 2.1.3.
  • Update to 2.1.3
  • Add DISTVERSIONPREFIX
  • Add CONFLICTS
acm marked an inline comment as done.Aug 30 2018, 5:44 AM
mixxx/Makefile
5–6

This should probably be DISTVERSION.

17

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm retitled this revision from audio/mixxx update to 2.1.3 to audio/mixxx update to 2.1.4.
  • Update to 2.1.4
  • Some minor changes
acm marked 2 inline comments as done.Oct 24 2018, 6:04 AM
  • Remove FLAVOR support. QT4 will be deprecated soon. it'll use QT instead of