Page MenuHomeFreeBSD
Feed Advanced Search

Jun 29 2023

yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

Sadly, I had to revert this, with all these defines being ambiguously named I missed the fact that IN_BASE is only used in FreeBSD-specific code to signify userland/kernel differences, while IN_FREEBSD_BASE really means FreeBSD-specific code inside the common code. Will need to think more about proper approach (and naming?) here.

Jun 29 2023, 9:09 PM
yuripv added a reverting change for D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h: rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h".
Jun 29 2023, 9:07 PM
yuripv added a reverting change for rGd2a45e9e817a: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h: rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h".
Jun 29 2023, 9:07 PM
yuripv committed rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h" (authored by yuripv).
Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h"
Jun 29 2023, 9:07 PM
yuripv closed D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.
Jun 29 2023, 8:18 PM
yuripv committed rGd2a45e9e817a: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h (authored by yuripv).
openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h
Jun 29 2023, 8:18 PM
yuripv committed rG24ec316c13bd: Correctly spell illumos (all lowercase) in man pages (authored by yuripv).
Correctly spell illumos (all lowercase) in man pages
Jun 29 2023, 11:49 AM

Jun 28 2023

yuripv added inline comments to D40690: setclasspriority(): New value 'inherit'.
Jun 28 2023, 10:43 AM
yuripv added inline comments to D40691: login.conf(5): Document priority's special value 'inherit'.
Jun 28 2023, 10:39 AM

Jun 19 2023

yuripv accepted D40601: seq: fix check for rounding error/truncation.
Jun 19 2023, 11:10 AM

May 30 2023

yuripv added inline comments to D40236: Fix NULL deref in ip_output during route change.
May 30 2023, 7:09 PM

May 23 2023

yuripv added inline comments to D40206: bectl.8: update /home.
May 23 2023, 4:10 PM

May 13 2023

yuripv updated the diff for D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

modify spa.h instead as proposed by Warner

May 13 2023, 5:08 PM

May 12 2023

yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

re: stand, I don't see a call to zpool_prop_init() in there anywhere, zpool_prop.c does not seem to be compiled as well; am I missing something obvious?

May 12 2023, 10:09 AM
yuripv added inline comments to D40074: vmm(4): document maxcpu tunable.
May 12 2023, 9:18 AM
yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

I *guess* it was done this way as it's the only FreeBSD-specific part in the "common" code, and everything using IN_BASE is located under sys/contrib/openzfs/lib/libzfs/os/freebsd and sys/contrib/openzfs/include/os/freebsd proper.

May 12 2023, 9:10 AM
yuripv requested review of D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.
May 12 2023, 12:09 AM

May 11 2023

yuripv requested review of D40074: vmm(4): document maxcpu tunable.
May 11 2023, 9:51 PM

May 10 2023

yuripv accepted D40051: md5: Add missing <errno.h>..
May 10 2023, 7:08 PM

May 9 2023

yuripv accepted D40018: md5: Include <osreldate.h> for __FreeBSD_version..
May 9 2023, 4:41 PM
yuripv added inline comments to D40018: md5: Include <osreldate.h> for __FreeBSD_version..
May 9 2023, 12:02 PM
yuripv abandoned D40015: md5: attempt fixing cross-builds in github ci.
May 9 2023, 12:01 PM
yuripv closed D39999: em(4): update sysctl list, mention iflib(4).
May 9 2023, 8:03 AM
yuripv committed rGb0cf48305f7f: em(4): update sysctl list, mention iflib(4) (authored by yuripv).
em(4): update sysctl list, mention iflib(4)
May 9 2023, 8:03 AM

May 8 2023

yuripv requested review of D40015: md5: attempt fixing cross-builds in github ci.
May 8 2023, 10:56 PM
yuripv committed rG7adea6dbed35: calendar: cleanup obsolete directories (authored by yuripv).
calendar: cleanup obsolete directories
May 8 2023, 10:50 PM
yuripv added inline comments to D39446: md5: Improve compatibility..
May 8 2023, 2:18 PM
yuripv committed rG1e37655ec389: vt(4): document enable_altgr (authored by yuripv).
vt(4): document enable_altgr
May 8 2023, 1:55 PM
yuripv closed D39997: vt(4): document enable_altgr.
May 8 2023, 1:55 PM
yuripv requested review of D39999: em(4): update sysctl list, mention iflib(4).
May 8 2023, 1:49 PM
yuripv requested review of D39997: vt(4): document enable_altgr.
May 8 2023, 10:35 AM

May 5 2023

yuripv committed rG66659955dafd: bhyve(8): fix typo in examples (authored by Alexey Marchenko <a.marchenko@miatel.ru>).
bhyve(8): fix typo in examples
May 5 2023, 1:16 PM
yuripv committed rG6abf81b3d674: pvscsi: maximum target number is one less than number of targets (authored by yuripv).
pvscsi: maximum target number is one less than number of targets
May 5 2023, 9:56 AM
yuripv closed D39867: pvscsi: maximum target number is one less than number of targets.
May 5 2023, 9:56 AM

May 4 2023

yuripv added a comment to D39867: pvscsi: maximum target number is one less than number of targets.

Warner, are you OK with the explanation above?

May 4 2023, 11:12 AM

Apr 28 2023

yuripv added a comment to D39867: pvscsi: maximum target number is one less than number of targets.

About my note:

Apr 28 2023, 4:25 PM
yuripv added a comment to D39867: pvscsi: maximum target number is one less than number of targets.
In D39867#907602, @imp wrote:

Is it better to fix it here, or where sc->max_targets is set? What's the source of this number, and how did it come to be off by one? And does vmware do it wrong consistently? Or is this nothing more than the 'number of targets' vs 'maximum target because we start at 0' issue other SIMs cope with?

Apr 28 2023, 4:02 PM
yuripv added a reviewer for D39867: pvscsi: maximum target number is one less than number of targets: vbhakta_vmware.com.
Apr 28 2023, 12:04 PM
yuripv added a reviewer for D39867: pvscsi: maximum target number is one less than number of targets: imp.
Apr 28 2023, 12:03 PM
yuripv requested review of D39867: pvscsi: maximum target number is one less than number of targets.
Apr 28 2023, 11:59 AM

Apr 27 2023

yuripv committed rG08ed87514f92: tzsetup: appease checkstyle9 (authored by yuripv).
tzsetup: appease checkstyle9
Apr 27 2023, 6:39 PM
yuripv requested review of D39857: fnmatch: use collation for ranges only for single-byte locales.
Apr 27 2023, 6:18 PM
yuripv committed rGcfd0217aa9a9: tzsetup: adopt zone1970.tab changes (authored by yuripv).
tzsetup: adopt zone1970.tab changes
Apr 27 2023, 5:40 PM
yuripv closed D39606: tzsetup: adopt zone1970.tab changes.
Apr 27 2023, 5:40 PM
yuripv updated the diff for D39606: tzsetup: adopt zone1970.tab changes.

rebase after baseline integration

Apr 27 2023, 10:20 AM

Apr 26 2023

yuripv committed rG989a0e1d81df: tzsetup: fix bootstrapping for github CI jobs (authored by yuripv).
tzsetup: fix bootstrapping for github CI jobs
Apr 26 2023, 12:32 PM
yuripv committed rG01007472eadd: getconf(1): add DEALLOC_PRESENT (authored by yuripv).
getconf(1): add DEALLOC_PRESENT
Apr 26 2023, 11:16 AM
yuripv closed D39796: getconf(1): add DEALLOC_PRESENT.
Apr 26 2023, 11:16 AM

Apr 25 2023

yuripv requested review of D39796: getconf(1): add DEALLOC_PRESENT.
Apr 25 2023, 9:44 AM

Apr 23 2023

yuripv added inline comments to D39634: tzsetup: add baseline file to control parsed zonetab contents.
Apr 23 2023, 10:12 AM
yuripv committed rG336c4682b6f3: tzsetup: add baseline file to control parsed zonetab contents (authored by yuripv).
tzsetup: add baseline file to control parsed zonetab contents
Apr 23 2023, 9:32 AM
yuripv closed D39634: tzsetup: add baseline file to control parsed zonetab contents.
Apr 23 2023, 9:31 AM
yuripv committed rGf70719fcbd30: libcasper: remove leftover debug directory (authored by yuripv).
libcasper: remove leftover debug directory
Apr 23 2023, 8:23 AM
yuripv closed D39756: libcasper: remove leftover debug directory.
Apr 23 2023, 8:22 AM

Apr 21 2023

yuripv requested review of D39756: libcasper: remove leftover debug directory.
Apr 21 2023, 11:28 PM
yuripv updated the diff for D39606: tzsetup: adopt zone1970.tab changes.

rebase on D39634

Apr 21 2023, 8:04 AM
yuripv updated the diff for D39634: tzsetup: add baseline file to control parsed zonetab contents.

fix uninitialized variable

Apr 21 2023, 8:02 AM

Apr 20 2023

yuripv updated the diff for D39634: tzsetup: add baseline file to control parsed zonetab contents.

move baseline file to usr.sbin/tzsetup to not clobber seemingly unrelated share/zoneinfo

Apr 20 2023, 11:07 AM
yuripv updated the test plan for D39606: tzsetup: adopt zone1970.tab changes.
Apr 20 2023, 11:00 AM

Apr 19 2023

yuripv accepted D39707: openssh: restore PrintLastLog option.
Apr 19 2023, 11:46 PM
yuripv committed rG4fee5114c374: tzsetup(8): update paths to zone tab and tzdata source (authored by yuripv).
tzsetup(8): update paths to zone tab and tzdata source
Apr 19 2023, 11:59 AM
yuripv closed D39643: tzsetup(8): update paths to zone tab and tzdata source.
Apr 19 2023, 11:58 AM

Apr 18 2023

yuripv updated the diff for D39634: tzsetup: add baseline file to control parsed zonetab contents.
  • make -d take path to zonetab file, so that baseline target uses the zone1970.tab in src and not from installed system
  • update summary to explain why ${SRCTOP}/share/zoneinfo location
Apr 18 2023, 10:28 AM
yuripv requested review of D39643: tzsetup(8): update paths to zone tab and tzdata source.
Apr 18 2023, 9:47 AM
yuripv added a comment to D39634: tzsetup: add baseline file to control parsed zonetab contents.

I like this idea, but I don't think this should live under /usr/share/zoneinfo. I believe that zoneinfo should *only* contain files generated by tzdata.

Maybe this should live in /usr/share/misc instead?

Apr 18 2023, 1:21 AM
yuripv requested review of D39634: tzsetup: add baseline file to control parsed zonetab contents.
Apr 18 2023, 12:58 AM

Apr 17 2023

yuripv committed rG21ef48af5c0f: xargs: improve foundeof check for -E (authored by yuripv).
xargs: improve foundeof check for -E
Apr 17 2023, 8:22 PM
yuripv closed D39583: xargs: improve foundeof check for -E.
Apr 17 2023, 8:22 PM
yuripv added reviewers for D39583: xargs: improve foundeof check for -E: bapt, kevans.
Apr 17 2023, 2:43 PM
yuripv updated the diff for D39606: tzsetup: adopt zone1970.tab changes.

deduplicate added code

Apr 17 2023, 11:39 AM

Apr 16 2023

yuripv updated the diff for D39606: tzsetup: adopt zone1970.tab changes.

grrrr, sorry, really upload the updated patch

Apr 16 2023, 3:05 PM
yuripv updated the diff for D39606: tzsetup: adopt zone1970.tab changes.

number continent entries consistently with lower-level menus

Apr 16 2023, 3:03 PM
yuripv added reviewers for D39606: tzsetup: adopt zone1970.tab changes: bapt, tmunro.
Apr 16 2023, 2:56 PM
yuripv requested review of D39606: tzsetup: adopt zone1970.tab changes.
Apr 16 2023, 2:51 PM

Apr 15 2023

yuripv requested review of D39583: xargs: improve foundeof check for -E.
Apr 15 2023, 5:27 PM

Apr 12 2023

yuripv added a comment to D39395: Hyper-V framebuffer driver.

Has this change been tested?

Apr 12 2023, 11:45 AM

Apr 7 2023

yuripv added inline comments to D39456: ipmi: check compcode from GETMSG.
Apr 7 2023, 8:12 PM
yuripv updated the diff for D39456: ipmi: check compcode from GETMSG.

added IPMI_GET_MSG_DATA_NA for 0x80 magic value

Apr 7 2023, 8:12 PM

Apr 6 2023

yuripv added a reviewer for D39456: ipmi: check compcode from GETMSG: philip.
Apr 6 2023, 8:30 PM
yuripv requested review of D39456: ipmi: check compcode from GETMSG.
Apr 6 2023, 8:28 PM

Apr 3 2023

yuripv updated the diff for D39395: Hyper-V framebuffer driver.
  • add sysctl to control the "fps"
  • add pnp entries
  • add to build
Apr 3 2023, 6:29 PM
yuripv updated the diff for D39395: Hyper-V framebuffer driver.

Add naive implementation of scheduled updates.

Apr 3 2023, 9:50 AM
yuripv requested review of D39395: Hyper-V framebuffer driver.
Apr 3 2023, 8:09 AM

Mar 31 2023

yuripv committed rG21f4e817fde7: hv_hid: Hyper-V HID driver (authored by yuri_aetern.org).
hv_hid: Hyper-V HID driver
Mar 31 2023, 7:56 PM

Mar 28 2023

yuripv committed rG269dea90d6eb: libc: use separate collate objects for C, POSIX, and C.UTF-8 (authored by yuripv).
libc: use separate collate objects for C, POSIX, and C.UTF-8
Mar 28 2023, 3:18 PM
yuripv closed D30146: libc: use separate collate objects for C, POSIX, and C.UTF-8.
Mar 28 2023, 3:18 PM
yuripv added a comment to D30146: libc: use separate collate objects for C, POSIX, and C.UTF-8.

Sorry, I completely forgot about this review, and now another PR was filed for the same problem. Could you please take another look? (I have updated the test case a bit for more complete switch testing).

Mar 28 2023, 2:55 PM
yuripv updated the diff for D30146: libc: use separate collate objects for C, POSIX, and C.UTF-8.

update the test case to make it cover all switches between these locales
add the spdx identifier

Mar 28 2023, 2:53 PM

Mar 27 2023

yuripv closed D37709: nvmecontrol(8): fix resv register -i synopsis.
Mar 27 2023, 1:04 PM
yuripv committed rG21af4e09f4e8: nvmecontrol(8): fix resv register -i synopsis (authored by yuripv).
nvmecontrol(8): fix resv register -i synopsis
Mar 27 2023, 1:04 PM
yuripv committed rG6aa5b10d0c24: nvme: fix resv commands with nda device (authored by yuripv).
nvme: fix resv commands with nda device
Mar 27 2023, 12:55 PM
yuripv closed D37696: nvme: fix resv commands with nda device.
Mar 27 2023, 12:55 PM
yuripv committed rG12496806098d: kern.post.mk: fix PORTSDIR handling (authored by yuripv).
kern.post.mk: fix PORTSDIR handling
Mar 27 2023, 12:00 PM
yuripv closed D37868: kern.post.mk: fix PORTSDIR handling.
Mar 27 2023, 12:00 PM

May 6 2021

yuripv requested review of D30146: libc: use separate collate objects for C, POSIX, and C.UTF-8.
May 6 2021, 10:00 AM

Apr 24 2021

yuripv added inline comments to D29917: BeFS support for fstyp command.
Apr 24 2021, 7:20 AM
yuripv added inline comments to D29917: BeFS support for fstyp command.
Apr 24 2021, 7:11 AM

Apr 19 2021

yuripv added a comment to D29584: Newly added features and bug fixes in latest Microchip SmartPQI driver..

With this patch applied, it fails much faster for me completely locking up ZFS, usually after some minutes of light load (e.g. I was doing git gc when this happened):

[ERROR]::[4:655.0][CPU 0][pqisrc_heartbeat_timer_handler][178]:controller is offline
(da1:smartpqi0:0:65:0): WRITE(10). CDB: 2a 00 05 82 4f e0 00 07 e8 00
(da2:smartpqi0:0:66:0): WRITE(10). CDB: 2a 00 05 82 7d 98 00 00 58 00
(da1:smartpqi0:0:65:0): CAM status: Unable to abort CCB request
(da1:smartpqi0:0:65:0): Error 5, Unretryable error
(da1:smartpqi0:0:65:0): WRITE(10). CDB: 2a 00 05 82 67 98 00 07 e8 00
(da1:smartpqi0:0:65:0): CAM status: Unable to abort CCB request
(da1:smartpqi0:0:65:0): Error 5, Unretryable error
...
da0 at smartpqi0 bus 0 scbus0 target 64 lun 0
da0: <ATA WDC WD40PURZ-85A 0A80>  s/n WD-WX32D7088CCV detached
(da1:smartpqi0:0:65:0): Error 5, Unretryable error
(da1:smartpqi0:0:65:0): WRITE(10). CDB: 2a 00 05 82 38 28 00 07 e8 00
(da1:smartpqi0:0:65:0): CAM status: Unable to abort CCB request
(da1:smartpqi0:0:65:0): Error 5, Unretryable error
da1 at smartpqi0 bus 0 scbus0 target 65 lun 0
da1: <ATA WDC WD40PURZ-85A 0A80>  s/n WD-WX42D70CHZS7 detached
(da2:smartpqi0:0:66:0): CAM status: Unable to abort CCB request
(da2:smartpqi0:0:66:0): Error 5, Unretryable error
(da2:smartpqi0:0:66:0): WRITE(10). CDB: 2a 00 05 82 75 b0 00 07 e8 00
(da2:smartpqi0:0:66:0): CAM status: Unable to abort CCB request
(da2:smartpqi0:0:66:0): Error 5, Unretryable error
da2 at smartpqi0 bus 0 scbus0 target 66 lun 0
da2: <ATA WDC WD40PURZ-85A 0A80>  s/n WD-WXC2D90D7YAX detached
da3 at smartpqi0 bus 0 scbus0 target 67 lun 0
da3: <ATA WDC WD40PURZ-85A 0A80>  s/n WD-WX12DB0N8F4X detached
ses0 at smartpqi0 bus 0 scbus0 target 68 lun 0
ses0: <Adaptec Smart Adapter 3.53>  s/n 7A4263EAB3E     detached
pass5 at smartpqi0 bus 0 scbus0 target 1088 lun 1
pass5: <Adaptec 1100-8i 3.53>  s/n 7A4263EAB3E     detached
(ses0:smartpqi0:0:68:0): Periph destroyed
(pass5:smartpqi0:0:1088:1): Periph destroyed
Solaris: WARNING: Pool 'data' has encountered an uncorrectable I/O failure and has been suspended.

Apr 16 11:36:45 sun ZFS[45956]: catastrophic pool I/O failure, zpool=data

Now every FS access is stuck. I was able to save the kernel dump using NMI (in case we can get something interesting from it).

This same system works just fine using the same HBA, same disks, same cabling under illumos (using our internal smartpqi driver) transferring TBs worth of data, so I don't expect this to be hardware issue.

HBA is 1100-8i, disks are 4x WDC WD40PURZ SATA3 HDDs, connected using breakout cable.

Thanks for testing the changes, The lockup issue is new to us. Could you please provide the Z-Pool reproduction steps so we can reflect the setup in our lab too for testing.

Apr 19 2021, 6:32 AM

Apr 17 2021

yuripv accepted D29813: Fix zgrep --version.
Apr 17 2021, 10:46 PM
yuripv accepted D27204: getprogname.3: Show difference between getprogname() and argv[0] in an example.
Apr 17 2021, 10:45 PM