Page MenuHomeFreeBSD

tzsetup: adopt zone1970.tab changes
ClosedPublic

Authored by yuripv on Apr 16 2023, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 7:46 AM
Unknown Object (File)
Sun, Apr 28, 1:02 AM
Unknown Object (File)
Mar 20 2024, 8:02 PM
Unknown Object (File)
Mar 17 2024, 6:38 PM
Unknown Object (File)
Mar 17 2024, 6:38 PM
Unknown Object (File)
Mar 17 2024, 6:37 PM
Unknown Object (File)
Mar 15 2024, 8:06 AM
Unknown Object (File)
Mar 15 2024, 8:06 AM
Subscribers

Details

Summary
  • assumption that single-zone countries do not have description is no longer correct; do not try to optimize this case as it's only going to make the code more confusing and we now have menus with a single zone selection because of this
  • remove the single-country continent short cut, it also only serves to confuse users as we now have such a continent
  • instead add a single-zone contry short cut (see above), now all single-zone countries fall here
  • use the @# continent overrides that zone1970.tab introduces (this is visible at least fixing Iceland being currently listed under Africa)
  • add Arctic Ocean "continent" coming only from the overrides at the moment
  • update baseline with the changes
Test Plan

The only really possible testing here is checking that tzsetup can parse zone1970.tab and provided selections still make sense; the latter should be covered by D39634.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

number continent entries consistently with lower-level menus

grrrr, sorry, really upload the updated patch

yuripv removed reviewers: bapt, tmunro.
yuripv retitled this revision from tzsetup: make use of the #@ continent overrides to tzsetup: adopt zone1970.tab changes.
yuripv edited the summary of this revision. (Show Details)

rebase on D39634

rebase after baseline integration

bapt added a reviewer: tljeffer_gmail.com.
bapt edited reviewers, added: philip; removed: tljeffer_gmail.com.
bapt added a subscriber: bapt.

LGTM, I added @philip as he has been updating the tzdata for a while now, so I might have an opinion

This revision is now accepted and ready to land.Apr 27 2023, 11:16 AM

Thank you very much!

I gave this a cursory test, and it looks like it works. Thank you for doing this work.

This revision was automatically updated to reflect the committed changes.