Page MenuHomeFreeBSD

tmunro (Thomas Munro)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 11:01 AM (110 w, 1 d)

Recent Activity

Yesterday

tmunro added a comment to D27353: ffs: do not read full direct blocks if they are going to be overwritten..

Hmm. My filesystem has 32kb blocks, and this generates reads, according to dwatch -X io:

Tue, Nov 24, 11:29 PM

Sun, Nov 8

tmunro closed D17166: Add a way to get version information from querylocale(3)..
Sun, Nov 8, 2:50 AM
tmunro committed rS367476: Add collation version support to querylocale(3)..
Add collation version support to querylocale(3).
Sun, Nov 8, 2:50 AM

Jul 12 2020

tmunro committed rS363126: MFC r340655.
MFC r340655
Jul 12 2020, 10:07 AM
tmunro committed rS363124: MFC r344656.
MFC r344656
Jul 12 2020, 9:50 AM

Jun 23 2020

tmunro requested review of D25160: ufs: add O_DSYNC support.
Jun 23 2020, 3:26 AM

Jun 21 2020

tmunro closed D25024: VFS: Track sequential reads and writes separately.
Jun 21 2020, 8:51 AM
tmunro committed rS362460: vfs: track sequential reads and writes separately.
vfs: track sequential reads and writes separately
Jun 21 2020, 8:51 AM

Jun 17 2020

tmunro added a comment to D25024: VFS: Track sequential reads and writes separately.
In D25024#551329, @kib wrote:

I think that currently f_nextoff is often redundant, and this can be used to avoid further extending the size of the struct. Most of the time, I believe, f_nextoff == f_offset. You can use this to consider both f_offset/f_nextoff as the pointers to two streams of accesses. More, it could serve a situation where you have e.g. two read streams, instead of current patch insistence of one stream being read and one write.

Jun 17 2020, 2:59 AM

Jun 2 2020

tmunro added inline comments to D25071: aio_fsync(O_DSYNC).
Jun 2 2020, 1:15 PM
tmunro updated the diff for D25071: aio_fsync(O_DSYNC).
Jun 2 2020, 1:12 PM
tmunro updated the diff for D25090: Add O_DSYNC support to open(2) and fcntl(2)..
Jun 2 2020, 10:48 AM

Jun 1 2020

tmunro added a comment to D25071: aio_fsync(O_DSYNC).
In D25071#552096, @kib wrote:

I believe that my main objection against defining O_DSYNC as O_SYNC was that it de-facto provides some intentionally wrong ABI. Defining O_DSYNC as you did, and converting it to IO_DSYNC or better IO_DATASYNC is fine even if no filesystem handle the flag differently from IO_SYNC ATM.

Jun 1 2020, 1:12 PM
tmunro added a comment to D25071: aio_fsync(O_DSYNC).

Thanks for the feedback!

Jun 1 2020, 12:51 PM
tmunro added inline comments to D25071: aio_fsync(O_DSYNC).
Jun 1 2020, 12:50 PM
tmunro updated the diff for D25071: aio_fsync(O_DSYNC).

Handled feedback from asomers@: added a test, added a missing check in aio_queue_file(), used -U999999 for more context. I also created a separate review ticket D25090 to add O_DSYNC for open(2) and fcntl(2). The present patch is rebased on top of that one.

Jun 1 2020, 12:48 PM
tmunro added inline comments to D25072: UFS: write inode block for fdatasync(2) if pointers in inode where allocated.
Jun 1 2020, 11:36 AM
tmunro added a comment to D25090: Add O_DSYNC support to open(2) and fcntl(2)..

Thanks! Fixed.

Jun 1 2020, 11:17 AM
tmunro updated the diff for D25090: Add O_DSYNC support to open(2) and fcntl(2)..
Jun 1 2020, 11:17 AM
tmunro updated the summary of D25090: Add O_DSYNC support to open(2) and fcntl(2)..
Jun 1 2020, 3:48 AM
tmunro updated the summary of D25090: Add O_DSYNC support to open(2) and fcntl(2)..
Jun 1 2020, 3:45 AM
tmunro requested review of D25090: Add O_DSYNC support to open(2) and fcntl(2)..
Jun 1 2020, 3:40 AM

May 30 2020

tmunro added a comment to D25072: UFS: write inode block for fdatasync(2) if pointers in inode where allocated.

This seems correct at a high level. It's required to read the data back. (For what it's worth, failure to distinguish between data integrity meta-data relating to file extension and frippery like mtime seems to have been a problem on other popular OSs' fdatasync(2) implementations in the past, which I think is what leads Postgres to trust fdatasync(2) only when it knows there has been a full fsync(2) since the last file size change. It would be cool to be able to save on some I/Os be being less paranoid.)

May 30 2020, 11:09 PM
tmunro requested review of D25071: aio_fsync(O_DSYNC).
May 30 2020, 2:56 PM

May 27 2020

tmunro updated the diff for D25024: VFS: Track sequential reads and writes separately.
May 27 2020, 10:32 PM
tmunro added a reviewer for D25024: VFS: Track sequential reads and writes separately: mjg.
May 27 2020, 10:35 AM
tmunro requested review of D25024: VFS: Track sequential reads and writes separately.
May 27 2020, 10:34 AM

Dec 13 2019

tmunro abandoned D17581: Convert tests of panicstr to KERNEL_PANICKED()..

Discussed with Mateusz, he would prefer to write a Coccinelle script to automate this change, so I am abandoning this patch.

Dec 13 2019, 10:37 AM

Oct 4 2019

tmunro updated the summary of D17166: Add a way to get version information from querylocale(3)..
Oct 4 2019, 1:59 AM

Aug 19 2019

tmunro committed rP509250: misc/zoneinfo: install zone1970.tab and other fixes.
misc/zoneinfo: install zone1970.tab and other fixes
Aug 19 2019, 3:09 AM
tmunro closed D20981: misc/zoneinfo: install zone1970.tab and other fixes.
Aug 19 2019, 3:09 AM
tmunro added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

Thanks for the reminder. I will commit this later today.

Aug 19 2019, 1:27 AM

Aug 2 2019

D21123: Teach ps(1) to select processes by parent process ID. now requires review to proceed.

Ok, based on feedback here and elsewhere, here's a version that uses getopt_long() from libc. It supports both --ppid (like Linux ps) and -P (like pgrep), and it seemed reasonable to add obvious long opts for --pid, --tty and --jail too. I decided not to try to add Linux-like --user, --User, --group, --Group in this patch (-u, -U, -g, -G all look a bit unportable and complicated). Thoughts?

Aug 2 2019, 11:35 AM

Jul 30 2019

tmunro created D21123: Teach ps(1) to select processes by parent process ID..
Jul 30 2019, 11:49 PM

Jul 18 2019

tmunro added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

Tested, the bad code removal works as described. +1 for getting rid of the BACKWARD zones by default, to match base. LGTM.

Jul 18 2019, 12:08 AM
tmunro added a reviewer for D20981: misc/zoneinfo: install zone1970.tab and other fixes: tmunro.
Jul 18 2019, 12:05 AM

Jul 17 2019

tmunro committed rS350079: tzsetup: upgrade to zone1970.tab.
tzsetup: upgrade to zone1970.tab
Jul 17 2019, 6:17 AM
tmunro closed D20646: Install and use /usr/share/zoneinfo/zone1970.tab.
Jul 17 2019, 6:17 AM

Jul 15 2019

tmunro updated subscribers of D20646: Install and use /usr/share/zoneinfo/zone1970.tab.
Jul 15 2019, 10:28 AM

Jun 29 2019

tmunro retitled D20646: Install and use /usr/share/zoneinfo/zone1970.tab from Install /usr/share/zoneinfo/zone1970.tab to Install and use /usr/share/zoneinfo/zone1970.tab.

I suppose we could update tzsetup(8) to use the new version too, if we're going to install it. So here's a patch that teaches that to handle the modern format with multi-country first field, and gets rid of the hardcoded "Arctic" menu because it went away in the data (concretely that means that people in https://en.wikipedia.org/wiki/Svalbard would need to choose Europe -> Norway, whose timezone they share as I assume they are well aware, being "a full part of the Kingdom of Norway").

Jun 29 2019, 10:39 AM

Jun 15 2019

tmunro created D20646: Install and use /usr/share/zoneinfo/zone1970.tab.
Jun 15 2019, 1:16 AM

Jun 6 2019

tmunro updated the diff for D20390: Show shm_open() and shmget() path/key in procstat -v..

Please re-read what I suggested in previous reply.

Jun 6 2019, 10:25 PM

May 25 2019

tmunro retitled D20390: Show shm_open() and shmget() path/key in procstat -v. from Show shm_open() paths in procstat -v. to Show shm_open() and shmget() path/key in procstat -v..
May 25 2019, 12:31 AM
tmunro updated the diff for D20390: Show shm_open() and shmget() path/key in procstat -v..

Got rid of allocation/copying.
Show POSIX segments as "(unlinked)" if their name has gone.
Show SysV segments with their key_t (same way it is displayed in ipcs output).

May 25 2019, 12:20 AM

May 23 2019

tmunro added a comment to D20390: Show shm_open() and shmget() path/key in procstat -v..

An obvious example of another user would be SysV shm. I suppose it should show the key (in hex format?) as the "path". Then of course you would use jail_adjust = false.

May 23 2019, 10:54 PM
tmunro created D20390: Show shm_open() and shmget() path/key in procstat -v..
May 23 2019, 10:23 PM

May 22 2019

tmunro accepted D20258: posixshmcontrol(1), an utility to query and manipulate named posix shm objects.
May 22 2019, 2:30 AM

May 20 2019

tmunro added inline comments to D20258: posixshmcontrol(1), an utility to query and manipulate named posix shm objects.
May 20 2019, 10:23 PM

May 18 2019

tmunro added a comment to D20258: posixshmcontrol(1), an utility to query and manipulate named posix shm objects.

Thanks for working on this! I took it for a quick spin and have some initial feedback.

May 18 2019, 12:51 AM

Feb 28 2019

tmunro closed D19295: Teach truss(1) about fsync(2) and fdatasync(2)..
Feb 28 2019, 9:13 AM
tmunro committed rS344656: truss: Add support for fsync(2) and fdatasync(2)..
truss: Add support for fsync(2) and fdatasync(2).
Feb 28 2019, 9:13 AM

Feb 22 2019

tmunro created D19295: Teach truss(1) about fsync(2) and fdatasync(2)..
Feb 22 2019, 12:01 PM

Nov 20 2018

tmunro committed rS340655: pom: Fix fencepost bugs..
pom: Fix fencepost bugs.
Nov 20 2018, 12:07 AM

Oct 28 2018

tmunro committed rS339840: truss: Fix display of shm_open(SHM_ANON, ...)..
truss: Fix display of shm_open(SHM_ANON, ...).
Oct 28 2018, 11:00 AM
tmunro closed D17461: truss: handle shm_open's special SHM_ANON value better..
Oct 28 2018, 11:00 AM

Oct 18 2018

tmunro committed rD52373: Add myself (tmunro) as a committer..
Add myself (tmunro) as a committer.
Oct 18 2018, 5:54 AM
tmunro closed D17605: Add myself (tmunro) as a committer..
Oct 18 2018, 5:54 AM
tmunro created D17605: Add myself (tmunro) as a committer..
Oct 18 2018, 5:39 AM

Oct 16 2018

tmunro updated the diff for D17581: Convert tests of panicstr to KERNEL_PANICKED()..

Here's a better version (the last one had an unintended stray change).
Note: this is a refactoring suggested by mjg, to support his future plans to change the representation of panic state to something small in __read_frequently. The new macro will hide those details from all these call sites, though for now it just does what it was doing before (with the addition of the prediction).

Oct 16 2018, 11:43 PM
tmunro added a reviewer for D17581: Convert tests of panicstr to KERNEL_PANICKED().: allanjude.
Oct 16 2018, 8:24 PM
tmunro created D17581: Convert tests of panicstr to KERNEL_PANICKED()..
Oct 16 2018, 11:04 AM