Page MenuHomeFreeBSD

papani.srikanth_microchip.com (PAPANI SRIKANTH)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 5:27 AM (63 w, 6 d)

Recent Activity

Mon, Apr 12

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Hi,

I have this slated for production in one week.
I will have to wait a couple of days to see if it fixes the hangs I have.

Mon, Apr 12, 7:43 AM
papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.
In D24428#663851, @imp wrote:

Can someone approve/review the code ?

I'll look at it this afternoon.

Do you also need someone to commit it to the FreeBSD tree too?

I would be happy if someone commit it to the repository.

Mon, Apr 12, 6:48 AM

Wed, Apr 7

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.
In D24428#663851, @imp wrote:

Can someone approve/review the code ?

I'll look at it this afternoon.

Do you also need someone to commit it to the FreeBSD tree too?

Wed, Apr 7, 2:49 AM

Tue, Apr 6

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Can someone approve/review the code ?

Tue, Apr 6, 7:55 AM
papani.srikanth_microchip.com added a comment to D29584: Newly added features and bug fixes in latest Microchip SmartPQI driver..

Can someone approve/review the code ?

Tue, Apr 6, 7:55 AM

Mon, Apr 5

papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Updated copyright section

Mon, Apr 5, 9:32 AM
papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.
In D24428#657918, @imp wrote:

There's issues with applying this patch. Something seems to have gone amiss in its generation.

It almost applied cleanly to stable/12 branch, but not to the main branch:

% find . -name \*.rej
./sys/dev/smartpqi/smartpqi_mem.c.rej
./sys/dev/smartpqi/smartpqi_queue.c.rej
./sys/dev/smartpqi/smartpqi_defines.h.rej
./sys/dev/smartpqi/smartpqi_cam.c.rej
./sys/dev/smartpqi/smartpqi_misc.c.rej
./sys/dev/smartpqi/smartpqi_main.c.rej
./sys/dev/smartpqi/smartpqi_request.c.rej

In the main branch, it crashed patch :(.
A quick sample of the .rej files shows the diffs likely are easy to resolve by hand, but with such a large patch I'm leery to do so. Add '-l' to patch to cope with whitespace changes didn't seem to help.
So it looks like this patch needs to be regenerated and/or moved to git where patch generation and uploading is a bit more reliable.

(Also commented on a couple of nits that didn't look quite right in the copyright stuff, but that can wait for the patch to get done).

Hi,

  • 12.0 stable branch and 12.2 main branch has two different source codes. I've pulled the 12.0 source code and applied the patch. (12.0 stable branch has bug fixes which is done by community but I do not see the same changes in 12.2 main branch because of that the patch is failing on 12.2 main branch).

"main" mentioned is literally main git branch, where this change should go first (and it's 14.0-CURRENT at the moment). I have HBA 1100-8i that is misbehaving under load, so I'd really like to try this patch -- could you please rebase this against main?

This patch is for 12.2 only, I will push a new patch separately to the main branch.

Is there a review/patch for main branch yet to test?

Here is the review patch for main branch.
https://reviews.freebsd.org/D29584

Mon, Apr 5, 2:48 AM
papani.srikanth_microchip.com added reviewers for D29584: Newly added features and bug fixes in latest Microchip SmartPQI driver.: Murthy.Bhat_microsemi.com, scott.benesh_microsemi.com, trasz, mav, imp, mjg, emaste, scottl.
Mon, Apr 5, 2:47 AM
papani.srikanth_microchip.com changed the repository for D29584: Newly added features and bug fixes in latest Microchip SmartPQI driver. from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Mon, Apr 5, 2:37 AM
papani.srikanth_microchip.com requested review of D29584: Newly added features and bug fixes in latest Microchip SmartPQI driver..
Mon, Apr 5, 2:34 AM

Wed, Mar 31

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.
In D24428#657918, @imp wrote:

There's issues with applying this patch. Something seems to have gone amiss in its generation.

It almost applied cleanly to stable/12 branch, but not to the main branch:

% find . -name \*.rej
./sys/dev/smartpqi/smartpqi_mem.c.rej
./sys/dev/smartpqi/smartpqi_queue.c.rej
./sys/dev/smartpqi/smartpqi_defines.h.rej
./sys/dev/smartpqi/smartpqi_cam.c.rej
./sys/dev/smartpqi/smartpqi_misc.c.rej
./sys/dev/smartpqi/smartpqi_main.c.rej
./sys/dev/smartpqi/smartpqi_request.c.rej

In the main branch, it crashed patch :(.
A quick sample of the .rej files shows the diffs likely are easy to resolve by hand, but with such a large patch I'm leery to do so. Add '-l' to patch to cope with whitespace changes didn't seem to help.
So it looks like this patch needs to be regenerated and/or moved to git where patch generation and uploading is a bit more reliable.

(Also commented on a couple of nits that didn't look quite right in the copyright stuff, but that can wait for the patch to get done).

Hi,

  • 12.0 stable branch and 12.2 main branch has two different source codes. I've pulled the 12.0 source code and applied the patch. (12.0 stable branch has bug fixes which is done by community but I do not see the same changes in 12.2 main branch because of that the patch is failing on 12.2 main branch).

"main" mentioned is literally main git branch, where this change should go first (and it's 14.0-CURRENT at the moment). I have HBA 1100-8i that is misbehaving under load, so I'd really like to try this patch -- could you please rebase this against main?

Wed, Mar 31, 5:24 PM

Fri, Mar 26

papani.srikanth_microchip.com updated the summary of D24428: smartpqi: Maintenance commit of Microchip smartpqi.
Fri, Mar 26, 3:20 PM
papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Updated driver.

Fri, Mar 26, 2:55 PM

Thu, Mar 25

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.
In D24428#657918, @imp wrote:

There's issues with applying this patch. Something seems to have gone amiss in its generation.

It almost applied cleanly to stable/12 branch, but not to the main branch:

% find . -name \*.rej
./sys/dev/smartpqi/smartpqi_mem.c.rej
./sys/dev/smartpqi/smartpqi_queue.c.rej
./sys/dev/smartpqi/smartpqi_defines.h.rej
./sys/dev/smartpqi/smartpqi_cam.c.rej
./sys/dev/smartpqi/smartpqi_misc.c.rej
./sys/dev/smartpqi/smartpqi_main.c.rej
./sys/dev/smartpqi/smartpqi_request.c.rej

In the main branch, it crashed patch :(.
A quick sample of the .rej files shows the diffs likely are easy to resolve by hand, but with such a large patch I'm leery to do so. Add '-l' to patch to cope with whitespace changes didn't seem to help.
So it looks like this patch needs to be regenerated and/or moved to git where patch generation and uploading is a bit more reliable.

(Also commented on a couple of nits that didn't look quite right in the copyright stuff, but that can wait for the patch to get done).

Thu, Mar 25, 9:51 AM

Mon, Mar 15

papani.srikanth_microchip.com edited reviewers for D24428: smartpqi: Maintenance commit of Microchip smartpqi, added: trasz; removed: deepak.ukey_microsemi.com, sbruno.
Mon, Mar 15, 11:02 AM
papani.srikanth_microchip.com added reviewers for D24428: smartpqi: Maintenance commit of Microchip smartpqi: emaste, mjg.
Mon, Mar 15, 10:57 AM

Feb 19 2021

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Please excuse me, I am only a user, I only try to get this working.

(f-hosting </root>) 130 # cd /usr/src
(f-hosting <src>) 0 # git apply /root/D24428.diff
/root/D24428.diff:1875: trailing whitespace.
_softs->pci_mem_handle.pqi_bhandle, _offset)
/root/D24428.diff:3930: space before tab in indent.

	DBG_FUNC("IN\n");

/root/D24428.diff:3944: space before tab in indent.

	DBG_FUNC("OUT\n");

/root/D24428.diff:6642: trailing whitespace.

  • Populate hostwellness time variables in bcd format from FreeBSD format

/root/D24428.diff:7949: space before tab in indent.

		sizeof(raid_req->lun_number));

error: dev/smartpqi/smartpqi_cam.c: No such file or directory
error: dev/smartpqi/smartpqi_cmd.c: No such file or directory
error: dev/smartpqi/smartpqi_defines.h: No such file or directory
error: dev/smartpqi/smartpqi_discovery.c: No such file or directory
error: dev/smartpqi/smartpqi_event.c: No such file or directory
error: dev/smartpqi/smartpqi_helper.c: No such file or directory
error: dev/smartpqi/smartpqi_includes.h: No such file or directory
error: dev/smartpqi/smartpqi_init.c: No such file or directory
error: dev/smartpqi/smartpqi_intr.c: No such file or directory
error: dev/smartpqi/smartpqi_ioctl.h: No such file or directory
error: dev/smartpqi/smartpqi_ioctl.c: No such file or directory
error: dev/smartpqi/smartpqi_main.c: No such file or directory
error: dev/smartpqi/smartpqi_mem.c: No such file or directory
error: dev/smartpqi/smartpqi_misc.c: No such file or directory
error: dev/smartpqi/smartpqi_prototypes.h: No such file or directory
error: dev/smartpqi/smartpqi_queue.c: No such file or directory
error: dev/smartpqi/smartpqi_request.c: No such file or directory
error: dev/smartpqi/smartpqi_response.c: No such file or directory
error: dev/smartpqi/smartpqi_sis.c: No such file or directory
error: dev/smartpqi/smartpqi_structures.h: No such file or directory
error: dev/smartpqi/smartpqi_tag.c: No such file or directory

I know it's not your job - but can you walk me through what I have got to do to get this to compile on 12.2-RELEASE-p3?

Feb 19 2021, 5:15 PM
papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Fixed system crash while creating and deleting logical volume in a continuous loop.
Fixed where the volume size is not exposing to OS when it expands.
Added HC3 pci id's.
Fixed compiler issues in 12.2 kernel.

I can't seem to apply the patch cleanly on 12.2-RELEASE-p3.

See my comment in the PR above.

Feb 19 2021, 4:17 PM
papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Fixed white space errors

Feb 19 2021, 3:45 PM

Feb 15 2021

papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Updated year in Copyright section.

Feb 15 2021, 5:20 PM
papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Fixed system crash while creating and deleting logical volume in a continuous loop.
Fixed where the volume size is not exposing to OS when it expands.
Added HC3 pci id's.
Fixed compiler issues in 12.2 kernel.

Feb 15 2021, 4:31 PM

Feb 12 2021

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

This does not compile with 12.2.

See
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240145

Can someone look at this?

Yes, we're working on the issues. I will update the latest driver soon.

Feb 12 2021, 1:05 PM

Jul 13 2020

papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Updated Inbox Driver version to match with latest Out-of-box driver 1x.4014.0.105

Jul 13 2020, 4:40 PM
papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Added newly fixed system crashes

Jul 13 2020, 7:34 AM

Jul 10 2020

papani.srikanth_microchip.com added a comment to D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Hi All,

Jul 10 2020, 9:38 AM

May 14 2020

papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

comments resolved

May 14 2020, 1:52 PM

May 7 2020

papani.srikanth_microchip.com updated the diff for D24428: smartpqi: Maintenance commit of Microchip smartpqi.

Added bug fixes which is happened recently

May 7 2020, 9:09 AM

Apr 15 2020

papani.srikanth_microchip.com updated the summary of D24428: smartpqi: Maintenance commit of Microchip smartpqi.
Apr 15 2020, 10:33 AM
papani.srikanth_microchip.com updated the summary of D24428: smartpqi: Maintenance commit of Microchip smartpqi.
Apr 15 2020, 10:24 AM
papani.srikanth_microchip.com created D24428: smartpqi: Maintenance commit of Microchip smartpqi.
Apr 15 2020, 10:13 AM