Page MenuHomeFreeBSD

smartpqi: clear CCBs allocated on the stack
ClosedPublic

Authored by trasz on May 16 2021, 8:26 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.May 16 2021, 8:26 PM

There is another smartpqi review that we need to be careful about landing since it's huge...

Indeed; I've added the author to the reviewers list.

(Also: tinderboxed.)

Indeed; I've added the author to the reviewers list.

(Also: tinderboxed.)

Can you please hold it for sometime if it's not blocking the other issue otherwise I would fix the merge conflicts again!

Meanwhile you can commit the https://reviews.freebsd.org/D24428 code since i do not have write access it seems

Indeed; I've added the author to the reviewers list.

(Also: tinderboxed.)

Can you please hold it for sometime if it's not blocking the other issue otherwise I would fix the merge conflicts again!

Meanwhile you can commit the https://reviews.freebsd.org/D24428 code since i do not have write access it seems

That's what I was hoping based when I raised the issue here

Sure, I'll hold off.

What's the relationship between https://reviews.freebsd.org/D24428 and https://reviews.freebsd.org/D30182?

  1. https://reviews.freebsd.org/D24428

SmartPQI code pushed on 12.2 branch.

2)https://reviews.freebsd.org/D30182
SmartPQI code pushed on 13.0 branch.

From SmartPQI driver side, the source code is same.

Sure, I'll hold off.

What's the relationship between https://reviews.freebsd.org/D24428 and https://reviews.freebsd.org/D30182?

  1. https://reviews.freebsd.org/D24428

SmartPQI code pushed on 12.2 branch.

2)https://reviews.freebsd.org/D30182
SmartPQI code pushed on 13.0 branch.

From SmartPQI driver side, the source code is same.

I've staged D30182 locally for committing. I've pushed that as described in the bug. Once the logistics of doing this for the first time are sorted, I'll MFC to stable/12 it using D24428. Once the first one it committed, we can fix it with this patch or something somewhat similar.

I've also staged this at https://github.com/bsdimp/freebsd/tree/D30182 and plan on pushing it at the same time with the changes from D30182. I had to make a minor tweak to get it to apply to the new code, so you may wish to take a look at it.

This revision is now accepted and ready to land.May 28 2021, 6:36 AM

Looks fine, please go ahead.

This revision was automatically updated to reflect the committed changes.