It's fine for me to commit it with at .Dd bump.
Thanks for the reminder.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 11 2020
Oct 10 2020
Oct 8 2020
OK from manpages. Remember to bump the .Dd when you commit this content change.
Oct 7 2020
OK from manpages.
Yes, I would remove it. We're using mandoc and people can install as many things from ports as they like, but we can't reflect that in our man pages.
Looks good, sorry for the wait.
Oct 5 2020
That's a good list of examples. Approved!
Looks good to me, thanks for adding these.
Useful to know about these, so approved. ;-)
Great, I like these. Approved!
Looks good, thanks for these examples.
Oct 3 2020
Man page changes look good to me.
Good to go now! Thanks.
Oct 2 2020
OK for the man page part of the patch.
Oct 1 2020
Two minor corrections...
Sep 30 2020
Nice, thanks for the changes.
Minor thing remaining, the rest looks good.
Sep 29 2020
Looks good to me.
Sep 28 2020
Ah, that's a good change. Approved1
Sep 25 2020
Looks good, thanks for adding these.
Sep 22 2020
Minor typo only. Did you run textproc/igor and "mandoc -Tlint" over them? I don't think they'll give any extra warning besides .Dd, but it does not hurt to check.
Thanks for writing these man pages.
Manpage is good now. Thanks.
Sep 21 2020
Also good from manpages (again).
Sep 15 2020
Sep 11 2020
Sep 10 2020
A fine addition to the chapter, well structured.
I've added a few comments and a suggestion inline.
Sep 7 2020
Looks good to me from the man page side of things.
Great, thanks for the followup fixes.
Minor nit, the rest looks good.
Sep 6 2020
In D26184#585678, @asomers wrote:@bcr unfortunately, mandoc has much to complain about with this man page. But none of its complaints were introduced by my change. Would you approve this PR as is, and then I can submit a separate one to fix the issues?
Sep 5 2020
OK from manpages.
Sep 2 2020
Sep 1 2020
Small correction. I like how thorough you've covered all the options.
Thanks for that!
Aug 31 2020
Grammo
Aug 28 2020
Thank you for your constant supply of useful EXAMPLES.
A few suggestions...
Looks good, thanks for the update.
Aug 27 2020
OK, thanks for the manpage checks. Good to go from our side of things.
Aug 26 2020
Can you check the man page with textproc/igor and "mandoc -Tlint" for any warnings?
In D26074#581749, @zec wrote:rgrimes: me being essentially a manpage rookie as well, unfortunately I can't provide an advice to Denis on how proceed from here. None of the lines fill entirely or extend past 80 columns, and all sentences are terminated by line breaks. What else should we improve re. formatting? As non-native English speakers, we can also try to improve text composition and flow a bit, but I guess this is not what you had in mind?
Aug 25 2020
Aug 24 2020
Thanks, it looks good to me now.
Typo and grammar fixes. In general, I like the examples.
Aug 21 2020
Looks good, thanks for adding these.
Can you run textproc/igor and "mandoc -Tlint" on the man page changes to see if they spit out any warnings?
Aug 20 2020
Approved, thanks for these additions.
Aug 19 2020
Some minor style comments...
Good to go. Thanks for checking and updating the man page.
Looks good to me from the man page side of things. I can't say much about the actual change though.
Aug 14 2020
OK, fine with me (a bit of a load on that machine, right?). ;-)
Aug 13 2020
OK from manpages (with .Dd bump needed).
Aug 11 2020
OK from manpages. Don't forget to bump the .Dd of the man page for this content change when you commit.
Thanks!
Aug 10 2020
Can we move ahead with this change or should the FAQ be fixed first?
Aug 8 2020
All good, thanks for taking care of it.
Aug 6 2020
Aug 5 2020
Approved and will be committed in a short while... Thank you!
Looks good, I'll commit this. Thank you!
Aug 4 2020
Any updates on the src part of the change?
The man page looks good. Can you check it with "mandoc -Tlint" and textproc/igor and see if they give you any warnings?
Thanks for writing that man page.
Minor textual suggestion for the man page (outside of your change).
Aug 3 2020
I approve as well.
Aug 1 2020
Looks good to me. A fine addition to have in the man page. Thanks!
Jul 31 2020
The addition sounds to me like that only HEX files have that comment (and hence is set in that case).
If that is not the case, I think writing: "... for BDF and HEX files ..." would make it clear that it applies to both.
That looks like a helpful addition, so approved! ;-)
Jul 30 2020
That looks good now. I'll get it committed. Thank you!
You're right, of course, @0mp.
I mixed it up with the markup for files.
Looks good to me. Thanks for the update, Gordon.
Good addition to have in the man page. Thanks!
Jul 29 2020
All good from manpages.
Jul 28 2020
This is an easy one, nevertheless important.
Good to go into the tree. Thanks!
Good catches, thank you for the patch! I'll get it committed.
Looks good to me.
An easy enough change. Thanks for it!