Page MenuHomeFreeBSD

bpf(4): Update the manual page to reflect reality
ClosedPublic

Authored by gbe on Aug 7 2020, 3:32 PM.

Details

Summary

bpf(4): Update the manual page to reflect reality

PR 131918

Test Plan

mandoc output review and 'mandoc -Tlint' checks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gbe requested review of this revision.Aug 7 2020, 3:32 PM
gbe created this revision.

Some minor style comments...

share/man/man4/bpf.4
687 ↗(On Diff #75567)

Is this early line break necessary here? I think you call pull the next line up to this one.

700 ↗(On Diff #75567)

Another early line break...

The summary of this review is lacking detail

share/man/man4/bpf.4
101 ↗(On Diff #75567)

Where did this information go? Should the list of of protocols be extended rather than deleted? Is data not still in network byte order and one should be using byteorder to extract values?

700 ↗(On Diff #75567)

Actually a wrong line break, the line break should be at the comma (,) after affect.

  • Fix two early line breaks.
gbe marked 3 inline comments as done.Aug 24 2020, 8:06 AM
share/man/man4/bpf.4
101 ↗(On Diff #75567)

The author of the original patch has deleted the information. I currently have not checked the code what protocols are supported. Since the original PR is from 2009, I invited network to have look.

I can of bring the paragraph back and extent it if necessary.

Could someone review the differential?

This revision is now accepted and ready to land.Oct 9 2020, 2:51 PM
This revision was automatically updated to reflect the committed changes.