Page MenuHomeFreeBSD

Improvements for src.conf(5) and build(7) man pages
ClosedPublic

Authored by gbe on Sep 6 2020, 7:43 AM.

Details

Summary

src.conf(5)

  • update the description

build(7)

  • update the headline
  • clarify how make(1) is executed
  • mention src.conf(5)

PR: 203863 (based on)

Test Plan

mandoc output review and 'mandoc -Tlint' checks

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gbe requested review of this revision.Sep 6 2020, 7:43 AM
gbe created this revision.

Could someone review this?

bcr added a subscriber: bcr.

Looks good to me from the man page side of things.

@imp and @jmp could you take a look at this differential?

The original PR was generated after some mailing list discussions based on your feedback.

@imp and @jmp what do you think about this differential? It is based on your mailing list feedback, even it was while ago!

share/man/man7/build.7
600 ↗(On Diff #76703)

lower case here.

tools/build/options/makeman
160 ↗(On Diff #76703)

This gives me heartburn. src.conf applies to all src trees you might have in the system...

  • PR 203863: Correct differential comments by @imp
gbe marked 2 inline comments as done.Sep 11 2020, 5:03 PM
gbe added inline comments.
tools/build/options/makeman
160 ↗(On Diff #76703)

I removed /usr/src.

I'm happy now. Thanks for listening to my feedback.

tools/build/options/makeman
160 ↗(On Diff #76703)

perfect. thanks!

This revision is now accepted and ready to land.Sep 11 2020, 5:05 PM
This revision was automatically updated to reflect the committed changes.
gbe marked an inline comment as done.