Page MenuHomeFreeBSD
Differential D25857

Add approximate location
ClosedPublic
Actions

Authored by debdrup on Jul 28 2020, 1:55 PM.
Tags
None
Referenced Files
F81613329: D25857.diff
Thu, Apr 18, 11:36 PM
Unknown Object (File)
Wed, Apr 17, 1:57 AM
Unknown Object (File)
Sat, Apr 13, 1:35 PM
Unknown Object (File)
Dec 20 2023, 8:11 AM
Unknown Object (File)
Sep 20 2023, 9:33 PM
Unknown Object (File)
Sep 20 2023, 4:06 PM
Unknown Object (File)
Dec 24 2022, 9:26 PM
Unknown Object (File)
Nov 26 2022, 8:19 PM
Subscribers
mat

Details

Reviewers
0mp
allanjude
bcr
Commits
rP543654: As part of onboarding, add approximate location as an xearth marker, while
Summary

As part of the onboarding process, add an approximate location as an
xearth marker

Test Plan

Igor'ing

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

debdrup created this revision.Jul 28 2020, 1:55 PM
Herald added a subscriber: mat. · View Herald TranscriptJul 28 2020, 1:55 PM
debdrup requested review of this revision.Jul 28 2020, 1:55 PM
Harbormaster completed remote builds in B32611: Diff 75064.Jul 28 2020, 1:55 PM
bcr accepted this revision.Jul 28 2020, 2:20 PM

Looks good to me.

This revision is now accepted and ready to land.Jul 28 2020, 2:20 PM
allanjude accepted this revision.Jul 28 2020, 7:45 PM

Approved By: allanjude (mentor)

0mp accepted this revision.Jul 29 2020, 10:25 AM

I wasn't sure what's the sorting order here but now I get it. LGTM

Closed by commit rP543654: As part of onboarding, add approximate location as an xearth marker, while (authored by debdrup). · Explain WhyJul 29 2020, 11:22 AM
This revision was automatically updated to reflect the committed changes.
debdrup added a commit: rP543654: As part of onboarding, add approximate location as an xearth marker, while.
mat added a comment.Aug 3 2020, 12:34 PM
In D25857#573058, @0mp wrote:

I wasn't sure what's the sorting order here but now I get it. LGTM

At the top of the file:

# Style (sorted from east to west): sort -n -r -k2

0mp added a comment.Aug 3 2020, 1:16 PM
In D25857#574442, @mat wrote:
In D25857#573058, @0mp wrote:

I wasn't sure what's the sorting order here but now I get it. LGTM

At the top of the file:

# Style (sorted from east to west): sort -n -r -k2

Yes, I found it there, thanks mat!

Revision Contents
Changeset List

PathSize
head/
astro/
xearth/
files/
1 line

Diff 75119

View Options

head/astro/xearth/files/freebsd.committers.markers

Loading...