Page MenuHomeFreeBSD

Add approximate location
ClosedPublic

Authored by debdrup on Tue, Jul 28, 1:55 PM.

Details

Summary

As part of the onboarding process, add an approximate location as an
xearth marker

Test Plan

Igor'ing

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

debdrup created this revision.Tue, Jul 28, 1:55 PM
debdrup requested review of this revision.Tue, Jul 28, 1:55 PM
bcr accepted this revision.Tue, Jul 28, 2:20 PM

Looks good to me.

This revision is now accepted and ready to land.Tue, Jul 28, 2:20 PM
allanjude accepted this revision.Tue, Jul 28, 7:45 PM

Approved By: allanjude (mentor)

0mp accepted this revision.Wed, Jul 29, 10:25 AM

I wasn't sure what's the sorting order here but now I get it. LGTM

mat added a comment.Mon, Aug 3, 12:34 PM
In D25857#573058, @0mp wrote:

I wasn't sure what's the sorting order here but now I get it. LGTM

At the top of the file:

# Style (sorted from east to west): sort -n -r -k2

0mp added a comment.Mon, Aug 3, 1:16 PM
In D25857#574442, @mat wrote:
In D25857#573058, @0mp wrote:

I wasn't sure what's the sorting order here but now I get it. LGTM

At the top of the file:

# Style (sorted from east to west): sort -n -r -k2

Yes, I found it there, thanks mat!