share/man/man4/linux.4
95	I wonder if we should perhaps default to YES? There's an existing problem, previously pointed out by tijl@, in that linux(4) tells the user to install linux_base-c7 package first, and then set linux_enable="YES"; however, install scripts for some of the linux packages might need those directories. I think we should flip the order (first enable, then "service linux start", then install linux_base-c7. Defaulting to YES would simplify the proces by removing one of the steps. In any case, you also need to add this variable to libexec/rc/rc.conf.

trasz added inline comments.Aug 31 2020, 12:01 PM

share/man/man4/linux.4
95	OTOH, it might be better to do that (flipping to YES and updating the installation instructions) in a subsequent commit.

otis updated this revision to Diff 76392.Aug 31 2020, 12:19 PM

otis marked 2 inline comments as done.

0mp added a project: rc.Sep 28 2020, 2:06 PM

Is there something I need to do with it, please?

Hello, and sorry for not getting to this earlier; I’m slowly going through my list of things that need to happen before 13.0.

One problem I have is this causes errors to be printed when the rc script is restarted; this is arguably a bug in install(1). On the other hand, the current script fails in that case anyway...

Is there something I need to do with it, please?

Sigh, sorry, it's my fault; every few months I got reminded about this, then find a problem, try to fix it, and then I get distracted and the cycle repeats.

There is the problem with install(1) described above, and also I'm not sure if we really need additional rc variable here. Given the fact that the patch doesn't apply anymore, can we perhaps just add it to https://reviews.freebsd.org/D32463, or add as a followup?

trasz mentioned this in D32463: rc.d/linux: Attempt to mount only if necessary.Nov 13 2021, 2:25 PM

Thanks!