Page MenuHomeFreeBSD

Document automatic handling of font height for BDF files
ClosedPublic

Authored by 0mp on Fri, Jul 31, 8:35 PM.

Details

Summary
Document automatic handling of font height for BDF files

PR:		248395
Reported by:	Dmitry Wagin <dmitry.wagin@ya.ru>

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248395

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp created this revision.Fri, Jul 31, 8:35 PM
0mp requested review of this revision.Fri, Jul 31, 8:35 PM
bcr added a subscriber: bcr.Fri, Jul 31, 9:00 PM

The addition sounds to me like that only HEX files have that comment (and hence is set in that case).
If that is not the case, I think writing: "... for BDF and HEX files ..." would make it clear that it applies to both.

tsoome added inline comments.Sat, Aug 1, 4:55 AM
usr.bin/vtfontcvt/vtfontcvt.8
66 ↗(On Diff #75231)

maybe something like:Font height is set automatically from FONTBOUNDINGBOX property for BFD files, and from Height comment for HEX files.

Font size for BDF font files is determined not only by FONTBOUNDINGBOX.

emaste accepted this revision.Sat, Aug 1, 3:05 PM

Agree we don't need to mention how height is set for bdf files as it is always set for them, it's only hex files that may not set it.

This revision is now accepted and ready to land.Sat, Aug 1, 3:05 PM
tsoome accepted this revision.Sat, Aug 1, 4:28 PM
This revision was automatically updated to reflect the committed changes.