Page MenuHomeFreeBSD
Differential D25907

Document automatic handling of font height for BDF files
ClosedPublic
Actions

Authored by 0mp on Jul 31 2020, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 3:58 AM
Unknown Object (File)
Mon, May 6, 10:59 AM
Unknown Object (File)
Sat, May 4, 3:26 PM
Unknown Object (File)
Fri, Apr 26, 2:44 AM
Unknown Object (File)
Thu, Apr 25, 9:09 PM
Unknown Object (File)
Thu, Apr 25, 9:00 PM
Unknown Object (File)
Apr 6 2024, 8:41 PM
Unknown Object (File)
Jan 28 2024, 2:39 AM
View All 28 Files
Subscribers
bcr
dmitry.wagin_ya.ru
imp

Details

Reviewers
emaste
tsoome
Group Reviewers
manpages
Commits
rS363771: Document automatic handling of font height for BDF files
Summary
Document automatic handling of font height for BDF files

PR:		248395
Reported by:	Dmitry Wagin <dmitry.wagin@ya.ru>

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248395

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32685
Build 30135: arc lint + arc unit

Event Timeline

0mp created this revision.Jul 31 2020, 8:35 PM
Herald added a reviewer: manpages. · View Herald TranscriptJul 31 2020, 8:35 PM
Herald added a subscriber: imp. · View Herald Transcript
0mp requested review of this revision.Jul 31 2020, 8:35 PM
Harbormaster completed remote builds in B32685: Diff 75231.Jul 31 2020, 8:35 PM
bcr added a subscriber: bcr.Jul 31 2020, 9:00 PM

The addition sounds to me like that only HEX files have that comment (and hence is set in that case).
If that is not the case, I think writing: "... for BDF and HEX files ..." would make it clear that it applies to both.

tsoome added inline comments.Aug 1 2020, 4:55 AM
usr.bin/vtfontcvt/vtfontcvt.8
66

maybe something like:Font height is set automatically from FONTBOUNDINGBOX property for BFD files, and from Height comment for HEX files.

dmitry.wagin_ya.ru added a subscriber: dmitry.wagin_ya.ru.Aug 1 2020, 2:45 PM
dmitry.wagin_ya.ru removed a subscriber: dmitry.wagin_ya.ru.Aug 1 2020, 2:49 PM
dmitry.wagin_ya.ru added a subscriber: dmitry.wagin_ya.ru.Aug 1 2020, 2:54 PM
dmitry.wagin_ya.ru added a comment.Aug 1 2020, 2:56 PM

Font size for BDF font files is determined not only by FONTBOUNDINGBOX.

emaste accepted this revision.Aug 1 2020, 3:05 PM

Agree we don't need to mention how height is set for bdf files as it is always set for them, it's only hex files that may not set it.

This revision is now accepted and ready to land.Aug 1 2020, 3:05 PM
tsoome accepted this revision.Aug 1 2020, 4:28 PM
Closed by commit rS363771: Document automatic handling of font height for BDF files (authored by 0mp). · Explain WhyAug 2 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rS363771: Document automatic handling of font height for BDF files.

Revision Contents
Changeset List

PathSize
usr.bin/
vtfontcvt/
6 lines

Diff 75231

View Options

usr.bin/vtfontcvt/vtfontcvt.8

Loading...