Page MenuHomeFreeBSD
Differential D31992

minidump: Use the provided dump bitset
ClosedPublic
Actions

Authored by mhorne on Sep 16 2021, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 13, 6:02 PM
Unknown Object (File)
Mon, Apr 13, 9:04 AM
Unknown Object (File)
Mon, Apr 13, 6:41 AM
Unknown Object (File)
Sun, Apr 12, 4:17 AM
Unknown Object (File)
Thu, Apr 9, 6:26 PM
Unknown Object (File)
Thu, Apr 9, 1:52 AM
Unknown Object (File)
Tue, Apr 7, 4:04 PM
Unknown Object (File)
Tue, Apr 7, 9:25 AM
View All Files
Subscribers
allanjude
andrew
emaste
imp
jhibbits

Details

Reviewers
manu
markj
kib
jhb
stevek
luporl
Commits
rG233ec6b12b56: minidump: Use the provided dump bitset
rG10fe6f80a6c8: minidump: Use the provided dump bitset
Summary

When constructing the set of dumpable pages, use the bitset provided by
the state argument, rather than assuming vm_page_dump invariably. For
normal kernel minidumps this will be a pointer to vm_page_dump, but when
dumping the live system it will not.

To do this, the functions in vm_dumpset.h are extended to accept the
desired bitset as an argument. Note that this provided bitset is assumed
to be derived from vm_page_dump, and therefore has the same size.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41550
Build 38439: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 16 2021, 6:40 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 16 2021, 6:40 PM
Herald added subscribers: Contributor Reviews (src), jhibbits, emaste and 2 others. · View Herald Transcript
mhorne requested review of this revision.Sep 16 2021, 6:40 PM
mhorne added a parent revision: D31991: minidump: Use provided msgbuf pointer.
Harbormaster completed remote builds in B41550: Diff 95263.Sep 16 2021, 6:40 PM
mhorne added a child revision: D31993: Allow minidumps to be performed on the live system.Sep 16 2021, 6:40 PM
mhorne added reviewers: markj, kib, jhb, stevek.Sep 16 2021, 6:44 PM
mhorne added a parent revision: D31989: minidump: Parameterize minidumpsys().
mhorne edited subscribers, added: allanjude; removed: Contributor Reviews (src).
mhorne added a reviewer: luporl.Sep 16 2021, 6:51 PM

This is mostly mechanical. state->dump_bitset should be used inside each minidump_machdep.c, and vm_page_dump everywhere else. The one exception to this is powerpc's dumpsys_scan_pmap() method, which is extended to also accept a bitset argument.

markj added inline comments.Sep 16 2021, 7:05 PM
sys/amd64/amd64/pmap.c
4953

I think it'd be better to provide a helper which fixes the vm_page_dump parameter. e.g., rename dump_add_page() to vm_page_dump_add() and make have dump_add_page() just be vm_page_dump_add(vm_page_dump, pa). It feels a bit silly to force all of the interface consumers outside of minidumpsys() to specify the global context which exists solely for the minidumpsys() implementation.

mhorne updated this revision to Diff 95476.Sep 21 2021, 6:56 PM

Add helpers to eliminate code churn outside of minidump_machdep.c.

Harbormaster completed remote builds in B41632: Diff 95476.Sep 21 2021, 6:56 PM
kib accepted this revision.Sep 22 2021, 7:30 PM
This revision is now accepted and ready to land.Sep 22 2021, 7:30 PM
markj accepted this revision.Sep 22 2021, 7:32 PM
jhb accepted this revision.Sep 23 2021, 5:01 PM
Closed by commit rG10fe6f80a6c8: minidump: Use the provided dump bitset (authored by mhorne). · Explain WhyNov 19 2021, 7:08 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG10fe6f80a6c8: minidump: Use the provided dump bitset.
mhorne added a commit: rG233ec6b12b56: minidump: Use the provided dump bitset.Dec 3 2021, 2:54 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
16 lines
12 lines
4 lines
arm/
arm/
10 lines
arm64/
arm64/
14 lines
8 lines
4 lines
i386/
i386/
10 lines
mips/
mips/
12 lines
6 lines
4 lines
powerpc/
aim/
10 lines
12 lines
include/
2 lines
2 lines
powerpc/
8 lines
2 lines
4 lines
riscv/
riscv/
10 lines
4 lines
4 lines
vm/
4 lines
16 lines
6 lines

Diff 95263

View Options

sys/amd64/amd64/minidump_machdep.c

Loading...
View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/amd64/uma_machdep.c

Loading...
View Options

sys/arm/arm/minidump_machdep.c

Loading...
View Options

sys/arm64/arm64/minidump_machdep.c

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/arm64/arm64/uma_machdep.c

Loading...
View Options

sys/i386/i386/minidump_machdep_base.c

Loading...
View Options

sys/mips/mips/minidump_machdep.c

Loading...
View Options

sys/mips/mips/pmap.c

Loading...
View Options

sys/mips/mips/uma_machdep.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/powerpc/include/dump.h

Loading...
View Options

sys/powerpc/include/mmuvar.h

Loading...
View Options

sys/powerpc/powerpc/minidump_machdep.c

Loading...
View Options

sys/powerpc/powerpc/pmap_dispatch.c

Loading...
View Options

sys/powerpc/powerpc/uma_machdep.c

Loading...
View Options

sys/riscv/riscv/minidump_machdep.c

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...
View Options

sys/riscv/riscv/uma_machdep.c

Loading...
View Options

sys/vm/uma_core.c

Loading...
View Options

sys/vm/vm_dumpset.h

Loading...
View Options

sys/vm/vm_page.c

Loading...