Page MenuHomeFreeBSD
Differential D30911

Modify sv_onexec hook to return error.
ClosedPublic
Actions

Authored by dchagin on Jun 26 2021, 10:19 AM.
Tags
None
Referenced Files
F163412592: D30911.id91391.diff
Thu, Jul 23, 12:01 AM
F163373538: D30911.id.diff
Wed, Jul 22, 3:15 PM
Unknown Object (File)
Wed, Jul 22, 8:38 AM
Unknown Object (File)
Tue, Jul 21, 1:11 AM
Unknown Object (File)
Sat, Jul 18, 2:36 PM
Unknown Object (File)
Sun, Jul 12, 8:11 PM
Unknown Object (File)
Fri, Jul 3, 5:03 PM
Unknown Object (File)
Mon, Jun 29, 10:37 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
kib
Commits
rG54689a282aee: linux(4): Modify sv_onexec hook to return an error.
rG5fd9cd53d256: linux(4): Modify sv_onexec hook to return an error.
Summary

Temporary add stubs to the Linux emulation layer which calls the existing hook.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40118
Build 37007: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 26 2021, 10:19 AM
Herald added a reviewer: manu. · View Herald TranscriptJun 26 2021, 10:19 AM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
dchagin requested review of this revision.Jun 26 2021, 10:19 AM
Harbormaster completed remote builds in B40115: Diff 91388.Jun 26 2021, 10:20 AM
dchagin added a reviewer: kib.Jun 26 2021, 10:20 AM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin added a parent revision: D30899: Call sv_onexec handler after the process VA is created..
dchagin added a child revision: D30900: linux(4); Almost complete the vDSO..
kib added inline comments.Jun 26 2021, 11:09 AM
sys/kern/kern_exec.c
1155

At this point, error is KERN_SUCCESS, which is some Mach error code. We never assume that it has zero value. Please replace this fragment by e.g. the following

return (sv->sv_onexec != NULL ? sv->sv_onexec(p, imgp) : 0);
dchagin updated this revision to Diff 91391.Jun 26 2021, 12:26 PM

fixed, i missied that KERN_SUCCESS != 0

Harbormaster completed remote builds in B40118: Diff 91391.Jun 26 2021, 12:26 PM
kib accepted this revision.Jun 26 2021, 1:57 PM

KERN_SUCCESS is 0, but it is undesirable to depend on that.

This revision is now accepted and ready to land.Jun 26 2021, 1:57 PM
Closed by commit rG5fd9cd53d256: linux(4): Modify sv_onexec hook to return an error. (authored by dchagin). · Explain WhyJul 20 2021, 7:10 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG5fd9cd53d256: linux(4): Modify sv_onexec hook to return an error..
dchagin added a commit: rG54689a282aee: linux(4): Modify sv_onexec hook to return an error..Jun 17 2022, 7:37 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
12 lines
linux32/
12 lines
arm64/
linux/
12 lines
i386/
linux/
14 lines
kern/
4 lines
sys/
2 lines

Diff 91391

View Options

sys/amd64/linux/linux_sysvec.c

Loading...
View Options

sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

sys/arm64/linux/linux_sysvec.c

Loading...
View Options

sys/i386/linux/linux_sysvec.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...
View Options

sys/sys/sysent.h

Loading...