Page MenuHomeFreeBSD

Add exec_sysvec_init_abi() to setup non native sysentvecs.
ClosedPublic

Authored by dchagin on Jun 25 2021, 3:45 PM.

Details

Summary

For future use in the Linux emulation layer add a new
exec_sysvec_init_abi() method which will fill timekeep_base and
sharedpage_obj for non native abi.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Can you de-duplicate this with exec_sysvec_init()? For instance, could you make exec_sysvec_init() call into your new function?

Perhaps your function would need to take some flags. Or better, parametrize exec_sysinit_abi() so that you can use it instead of make practically a copy.

sys/kern/kern_sharedpage.c
327–335

Why do you need to check this condition? The assert on the previous line verified that the condition is true.

here was a mistake, now it's ok, runtime tested.

sys/kern/kern_sharedpage.c
321–325

Add {} around then statement, it is multi-line.

355–356

This one should be conditional on ABI_FREEBSD as well, perhaps?

400

Should sv->sv_shared_page_obj == 0 (NULL BTW?) and sv->sv_shared_page_base != 0 asserts moved to exec_sysvec_init() ?

404

Now, with the changes to exec_sysvec_init(), what is the reason to have exec_sysvec_init_abi()? It only asserts some state.

sys/kern/kern_sharedpage.c
314

I think that this assert (sv_shared_page_base != 0) should be only done if SV_SHP flag is set.

indeed, fixed, now its good.

kib added inline comments.
sys/kern/kern_sharedpage.c
355

This can be written as a single check

((flags  & (SV_ABI_MASK | SV_RNG_SEED_VER) ) ==  (SV_ABI_FREEBSD | SV_RNG_SEED_VER))

but it is up to you.

This revision is now accepted and ready to land.Jun 26 2021, 1:55 PM