Page MenuHomeFreeBSD

linux(4): Fixup the vDSO initialization order.
ClosedPublic

Authored by dchagin on Jun 25 2021, 4:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 30, 3:47 AM
Unknown Object (File)
Tue, Jun 30, 1:05 AM
Unknown Object (File)
Sun, Jun 28, 4:50 AM
Unknown Object (File)
Fri, Jun 26, 2:28 AM
Unknown Object (File)
Thu, Jun 25, 9:38 AM
Unknown Object (File)
Tue, Jun 23, 8:11 PM
Unknown Object (File)
Sat, Jun 20, 7:13 PM
Unknown Object (File)
Mon, Jun 15, 4:08 PM
Subscribers

Details

Summary

The vDSO initialisation order should be as follows:

  • native abi init via exec_sysvec_init();
  • vDSO symbols queued to the linux_vdso_syms list;
  • linux_vdso_install();
  • linux_exec_sysvec_init();

As the exec_sysvec_init() called with SI_ORDER_ANY (last) at SI_SUB_EXEC
order, move linux_vdso_install() and linux_exec_sysvec_init() to the
SI_SUB_EXEC+1 order.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/amd64/linux/linux_sysvec.c
833

Since the + 1 carries no context I think it would be worth a comment, e.g. mentioning that exec_sysvec_init is SI_SUB_EXEC and this must be after?

This revision is now accepted and ready to land.Jul 9 2021, 2:02 PM