Page MenuHomeFreeBSD

Modify sv_onexec hook to return error.
ClosedPublic

Authored by dchagin on Jun 26 2021, 10:19 AM.
Tags
None
Referenced Files
F163412592: D30911.id91391.diff
Thu, Jul 23, 12:01 AM
Unknown Object (File)
Wed, Jul 22, 3:15 PM
Unknown Object (File)
Wed, Jul 22, 8:38 AM
Unknown Object (File)
Tue, Jul 21, 1:11 AM
Unknown Object (File)
Sat, Jul 18, 2:36 PM
Unknown Object (File)
Sun, Jul 12, 8:11 PM
Unknown Object (File)
Fri, Jul 3, 5:03 PM
Unknown Object (File)
Mon, Jun 29, 10:37 AM
Subscribers

Details

Summary

Temporary add stubs to the Linux emulation layer which calls the existing hook.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/kern/kern_exec.c
1167

At this point, error is KERN_SUCCESS, which is some Mach error code. We never assume that it has zero value. Please replace this fragment by e.g. the following

return (sv->sv_onexec != NULL ? sv->sv_onexec(p, imgp) : 0);

fixed, i missied that KERN_SUCCESS != 0

KERN_SUCCESS is 0, but it is undesirable to depend on that.

This revision is now accepted and ready to land.Jun 26 2021, 1:57 PM