Page MenuHomeFreeBSD

Modify sv_onexec hook to return error.
ClosedPublic

Authored by dchagin on Jun 26 2021, 10:19 AM.
Tags
None
Referenced Files
F82179496: D30911.diff
Fri, Apr 26, 5:47 AM
Unknown Object (File)
Wed, Apr 24, 2:41 PM
Unknown Object (File)
Wed, Apr 24, 2:38 PM
Unknown Object (File)
Wed, Apr 24, 2:37 PM
Unknown Object (File)
Wed, Apr 24, 2:37 PM
Unknown Object (File)
Sun, Apr 21, 8:18 PM
Unknown Object (File)
Feb 14 2024, 9:16 PM
Unknown Object (File)
Feb 14 2024, 9:16 PM
Subscribers

Details

Summary

Temporary add stubs to the Linux emulation layer which calls the existing hook.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40115
Build 37004: arc lint + arc unit

Event Timeline

sys/kern/kern_exec.c
1156

At this point, error is KERN_SUCCESS, which is some Mach error code. We never assume that it has zero value. Please replace this fragment by e.g. the following

return (sv->sv_onexec != NULL ? sv->sv_onexec(p, imgp) : 0);

fixed, i missied that KERN_SUCCESS != 0

KERN_SUCCESS is 0, but it is undesirable to depend on that.

This revision is now accepted and ready to land.Jun 26 2021, 1:57 PM