Page MenuHomeFreeBSD
Differential D28207

Add COM3 and COM4 to bhyve guests
ClosedPublic
Actions

Authored by otis on Jan 17 2021, 11:57 AM.
Tags
None
Referenced Files
F153496012: D28207.id82411.diff
Tue, Apr 21, 11:33 AM
Unknown Object (File)
Mon, Apr 20, 9:07 PM
Unknown Object (File)
Thu, Apr 16, 9:41 PM
Unknown Object (File)
Wed, Apr 15, 1:58 PM
Unknown Object (File)
Tue, Apr 7, 7:49 AM
Unknown Object (File)
Mon, Apr 6, 7:24 AM
Unknown Object (File)
Sun, Apr 5, 11:16 AM
Unknown Object (File)
Sat, Apr 4, 3:13 AM
View All Files
Subscribers
0mp
bcran
grehan
imp
rgrimes

Details

Reviewers
imp
grehan
0mp
Group Reviewers
bhyve
manpages
Commits
rGeed1cc6cdfa7: Support COM3 and COM4 serial ports.
Summary

While working on different project with bhyve (in particular, on SmartOS-based product), we ran into a situation where we needed all 4 COM ports inside a bhyve guest.

This patch adds them, it has already been tested in SmartOS.

Authored by Jan Poctavek <janci@binaryparadise.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36306
Build 33195: arc lint + arc unit

Event Timeline

otis requested review of this revision.Jan 17 2021, 11:57 AM
otis created this revision.
otis updated this revision to Diff 82429.Jan 17 2021, 5:38 PM
otis edited the summary of this revision. (Show Details)

Update the diff to be against FreeBSD. Previously it was against illumos.

Herald added a reviewer: bhyve. · View Herald TranscriptJan 17 2021, 5:38 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
Harbormaster completed remote builds in B36297: Diff 82429.Jan 17 2021, 5:39 PM
otis edited the summary of this revision. (Show Details)Jan 17 2021, 5:46 PM
imp accepted this revision.Jan 17 2021, 5:50 PM

Looks good to my eye, but I'd feel better with a nod from one of the main bhyve developers

This revision is now accepted and ready to land.Jan 17 2021, 5:50 PM
otis updated this revision to Diff 82444.Jan 17 2021, 11:11 PM
  • Fix manual page to mention com1 .. com4
This revision now requires review to proceed.Jan 17 2021, 11:11 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 17 2021, 11:11 PM
Harbormaster completed remote builds in B36305: Diff 82444.Jan 17 2021, 11:11 PM
grehan accepted this revision.Jan 17 2021, 11:16 PM
grehan added a subscriber: grehan.

Change looks useful, thanks.

usr.sbin/bhyve/bhyve.8
156–157

Should be 'through' based on usage in other man pages.

This revision is now accepted and ready to land.Jan 17 2021, 11:16 PM
0mp requested changes to this revision.Jan 17 2021, 11:17 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.sbin/bhyve/bhyve.8
156–157
This revision now requires changes to proceed.Jan 17 2021, 11:17 PM
0mp added inline comments.Jan 17 2021, 11:18 PM
usr.sbin/bhyve/bhyve.8
156–157

Exactly. Our automated proofreader igor does not like "thru" apparently.

otis updated this revision to Diff 82445.Jan 17 2021, 11:25 PM
  • thru -> through
otis marked 3 inline comments as done.Jan 17 2021, 11:26 PM
Harbormaster completed remote builds in B36306: Diff 82445.Jan 17 2021, 11:26 PM
0mp accepted this revision.Jan 18 2021, 1:22 PM

Thanks!

This revision is now accepted and ready to land.Jan 18 2021, 1:22 PM
Closed by commit rGeed1cc6cdfa7: Support COM3 and COM4 serial ports. (authored by grehan). · Explain WhyJan 19 2021, 8:23 AM
This revision was automatically updated to reflect the committed changes.
grehan added a commit: rGeed1cc6cdfa7: Support COM3 and COM4 serial ports..

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
6 lines
4 lines
6 lines

Diff 82445

View Options

usr.sbin/bhyve/bhyve.8

Loading...
View Options

usr.sbin/bhyve/pci_lpc.c

Loading...
View Options

usr.sbin/bhyve/uart_emul.c

Loading...