Differential D60194

ifuncs: Include <machine/ifunc.h> instead of <x86/ifunc.h>
ClosedPublic
Actions

Authored by olce on Thu, Oct 1, 9:25 AM.

Tags

None

Referenced Files

	F174679271: D60194.diff
	Mon, Oct 5, 3:43 AM

	F174661463: D60194.id188300.diff
	Mon, Oct 5, 1:06 AM

	F174660597: D60194.id188342.diff
	Mon, Oct 5, 12:58 AM

	Unknown Object (File)
	Sun, Oct 4, 10:58 AM

	Unknown Object (File)
	Sun, Oct 4, 3:53 AM

	Unknown Object (File)
	Sun, Oct 4, 3:29 AM

	Unknown Object (File)
	Sun, Oct 4, 2:24 AM

	Unknown Object (File)
	Sat, Oct 3, 11:03 PM

View All 19 Files

Subscribers

Details

Reviewers

markj
kib
gnn

Group Reviewers

Commits

rGa2fbd988638e: ifuncs: Include <machine/ifunc.h> instead of <x86/ifunc.h>

Summary

All architectures have been providing an 'ifunc.h' header with
DEFINE_IFUNC() et alter working both in kernel and userland since commit
cf41d1113377 ("riscv: implement kernel ifunc resolution"), and separate
<i386/ifunc.h> and <amd64/ifunc.h> headers were introduced in commit
2b1db07bec92 ("x86: add machine/ifunc.h"), so stop including
<x86/ifunc.h> directly and use the common <machine/ifunc.h> idiom.

While here, re-order includes in the blocks featuring <x86/ifunc.h>,
which requires fixing <x86/apicvar.h> so that it can be included before
<machine/intr_machdep.h>.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77574
Build 74457: arc lint + arc unit

Event Timeline

olce created this revision.Thu, Oct 1, 9:25 AM

Herald added a reviewer: gnn. · View Herald TranscriptThu, Oct 1, 9:25 AM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

olce requested review of this revision.Thu, Oct 1, 9:25 AM

Harbormaster completed remote builds in B77574: Diff 188300.Thu, Oct 1, 9:25 AM

kib accepted this revision.Thu, Oct 1, 6:18 PM

This revision is now accepted and ready to land.Thu, Oct 1, 6:18 PM

Closed by commit rGa2fbd988638e: ifuncs: Include <machine/ifunc.h> instead of <x86/ifunc.h> (authored by olce). · Explain WhyThu, Oct 1, 7:47 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGa2fbd988638e: ifuncs: Include <machine/ifunc.h> instead of <x86/ifunc.h>.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

4 lines

10 lines

8 lines

linux/

linux_machdep.c

2 lines

linux32/

linux32_machdep.c

2 lines

vmm/

12 lines

cddl/

dev/

dtrace/

amd64/

2 lines

i386/

i386/

4 lines

2 lines

2 lines

libkern/

2 lines

x86/

include/

3 lines

x86/

4 lines

Diff 188300

sys/amd64/amd64/copyout.c

Loading...

sys/amd64/amd64/fpu.c

Loading...

sys/amd64/amd64/machdep.c

Loading...

sys/amd64/amd64/pmap.c

Loading...

sys/amd64/linux/linux_machdep.c

Loading...

sys/amd64/linux32/linux32_machdep.c

Loading...

sys/amd64/vmm/vmm.c

Loading...

sys/cddl/dev/dtrace/amd64/dtrace_isa.c

Loading...

sys/i386/i386/npx.c

Loading...

sys/i386/i386/pmap.c

Loading...

sys/i386/i386/pmap_base.c

Loading...

sys/libkern/gsb_crc32.c

Loading...

sys/x86/include/apicvar.h

Loading...

sys/x86/x86/cpu_machdep.c

Loading...