if_bridge: count the drops of the fragmentation path
ClosedPublic
Actions

Authored by netchild on Fri, Sep 4, 1:52 PM.

Details

Reviewers

markj
glebius
gallatin

Commits

rG8209ceeb7504: if_bridge: count the drops on the fragmentation path

Summary

Add error counter handling in bridge_fragment().

Assisted-by: Claude Code (Fable 5, Opus 5)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76572
Build 73455: arc lint + arc unit

Event Timeline

netchild created this revision.Fri, Sep 4, 1:52 PM

netchild held this revision as a draft.

Herald added subscribers: ivy, melifaro, ae, imp. · View Herald TranscriptFri, Sep 4, 1:52 PM

Harbormaster completed remote builds in B76497: Diff 185821.Fri, Sep 4, 1:52 PM

netchild added a parent revision: D59333: pf tests: cover filtering of bridged unmapped mbufs.Fri, Sep 4, 1:52 PM

netchild published this revision for review.Fri, Sep 4, 1:53 PM

The following part may need to get a rework for this change... investigating...

		default:
			if (V_pfil_onlyip)
				goto bad;

rework: the bad: counter is removed; only the fragmentation path is counted

Harbormaster completed remote builds in B76572: Diff 185937.Sat, Sep 5, 5:12 PM

netchild retitled this revision from if_bridge: count the packets bridge_pfil() drops on error to if_bridge: count the drops of the fragmentation path.Sat, Sep 5, 5:23 PM

netchild edited the summary of this revision. (Show Details)

The bad: label in the previous revision gets called for ether types 0x88e1 (HomePlug AV management frames) and 0x8912 (not named in sys/net/ethernet.h) via the default: case and with net.link.bridge.pfil_onlyip=1. This looks to me like a policy drop and not an error path. As such I removed that part. Correct me if I get this wrong... (447 such packets in 300s doesn't not sound like an error to me).

gallatin accepted this revision.Tue, Sep 8, 12:14 PM

This revision is now accepted and ready to land.Tue, Sep 8, 12:14 PM

Closed by commit rG8209ceeb7504: if_bridge: count the drops on the fragmentation path (authored by netchild). · Explain WhyFri, Sep 11, 5:16 PM

This revision was automatically updated to reflect the committed changes.

netchild added a commit: rG8209ceeb7504: if_bridge: count the drops on the fragmentation path.