Page MenuHomeFreeBSD
Differential D59345

hastd: Add rudimentary tests
ClosedPublic
Actions

Authored by des on Thu, Sep 3, 3:19 PM.
Tags
None
Referenced Files
F170851204: D59345.diff
Mon, Sep 7, 1:13 AM
F170827681: D59345.diff
Sun, Sep 6, 9:21 PM
F170821260: D59345.id185931.diff
Sun, Sep 6, 8:29 PM
F170805029: D59345.id185851.diff
Sun, Sep 6, 6:08 PM
Unknown Object (File)
Sat, Sep 5, 6:36 PM
Unknown Object (File)
Sat, Sep 5, 2:34 AM
Unknown Object (File)
Sat, Sep 5, 2:06 AM
Unknown Object (File)
Fri, Sep 4, 8:45 AM
View All 13 Files
Subscribers
imp
ivy

Details

Reviewers
gjb
pjd
emaste
kevans
markj
Commits
rG4ec3ca55f9a7: hastd: Add rudimentary tests
Summary

Test that we can start and stop hastd with an empty configuration.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76521
Build 73404: arc lint + arc unit

Event Timeline

des created this revision.Thu, Sep 3, 3:19 PM
Herald added subscribers: ivy, imp. · View Herald TranscriptThu, Sep 3, 3:19 PM
des requested review of this revision.Thu, Sep 3, 3:19 PM
Harbormaster completed remote builds in B76428: Diff 185710.Thu, Sep 3, 3:19 PM
des updated this revision to Diff 185711.Thu, Sep 3, 3:19 PM
des added a parent revision: D59344: hastd: Add a stop control message.

whitespace

Harbormaster completed remote builds in B76429: Diff 185711.Thu, Sep 3, 3:19 PM
kevans accepted this revision.Fri, Sep 4, 6:11 PM
kevans added inline comments.
sbin/hastd/tests/hastd_test.sh
29

I suspect you want to truncate/remove the pid file in the body after stop, otherwise we're signalling a stale pid that hopefully wouldn't have been reused.

This revision is now accepted and ready to land.Fri, Sep 4, 6:11 PM
des updated this revision to Diff 185851.Fri, Sep 4, 6:42 PM

rf

This revision now requires review to proceed.Fri, Sep 4, 6:42 PM
Harbormaster completed remote builds in B76521: Diff 185851.Fri, Sep 4, 6:42 PM
kevans accepted this revision.Fri, Sep 4, 6:50 PM
This revision is now accepted and ready to land.Fri, Sep 4, 6:50 PM
Closed by commit rG4ec3ca55f9a7: hastd: Add rudimentary tests (authored by des). · Explain WhySat, Sep 5, 3:45 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG4ec3ca55f9a7: hastd: Add rudimentary tests.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
sbin/
hastd/
3 lines
tests/
4 lines
36 lines

Diff 185851

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

sbin/hastd/Makefile

Loading...
View Options

sbin/hastd/tests/Makefile

Loading...
View Options

sbin/hastd/tests/hastd_test.sh

Loading...