Add if_geneve manual
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 71864 Build 68747: arc lint + arc unit
Event Timeline
Comment Actions
Someone who understands network needs to also review this. I have little nits, but they honestly don't matter. This is amazing work!
| share/man/man4/geneve.4 | ||
|---|---|---|
| 2 | Nit: Honestly, I don't know why this empty line is here, but all our docs show to do it this way, but also some senior committers just stopped using it with no explanation lately | |
| 11 | please dont quote this, Nd interprets the rest of line | |
| 13–25 | Nit: consider using this style. we have almost 200 manuals that are written this way. I gave a talk about trying to get people to use it, and discussed it on arch@ in January. This is more consistent with what SYNOPSIS means in every other section of the manual as well as the rest of the BSD ecosystem. It also has the benefit of letting people search for more configuration directly. | |
| 160 | Nit: mdoc(7) (from upstream) suggests sticking to standard sections when possible, and using subsections of DESCRIPTION for describing. I, personally, think this very good, however, some people don't like it. | |
| 190 | mdoc(7) says please no parenthesis in titles | |
| 242 | This entire section gets copied verbatim into the hardware release notes. see style.mdoc for more info. | |
| share/man/man4/geneve.4 | ||
|---|---|---|
| 2 | To match the /* * Copyright ... * ... in C. It's stilly, but it's why this has been done for a long time. | |