ufshci: Support ACPI
ClosedPublic
Actions

Authored by jaeyoon on Mar 20 2026, 7:25 AM.

Details

Reviewers

imp

Commits

rGe2083e8d3a01: ufshci: Support ACPI

Summary

Supports UFS host controller attachment via ACPI. Tested on the
Samsung Galaxy Book 4 Edge using Qualcomm Snapdragon X Elite.
Additionally, a quirk related to power mode change has been added.

For reference, it doesn't reach maximum speed yet. I plan to improve
it later.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Mar 20 2026, 7:25 AM

jaeyoon created this revision.

jaeyoon added a parent revision: D55985: ufshci: add uic powermode parameter to sysctl.

imp added inline comments.Mar 20 2026, 1:46 PM

sys/dev/ufshci/ufshci_acpi.c
86	why is 0 treated special here? Generically, 0 is a fine UID number. Is there some guarantee that we won't need to match on UID 0, but no others (the way the code is now is 0 matches all UID, which seems sensible... though I wonder why we ever care about the UID to do quirk matching).
sys/dev/ufshci/ufshci_ctrlr.c
169	Would this code be better in its own function, even if it is a singleton?
360	This might be better on one line, even if it pushes past 80 columns. The alignment shown in phab is weird, we usually just indent 4 extra spaces.
362	Here I'd definitely fold the lines. Going over 80 columns by 1 or 2 characters is preferable.

Apply review comments.

Harbormaster completed remote builds in B71659: Diff 174149.Mar 23 2026, 6:06 AM

Thanks for the review!

sys/dev/ufshci/ufshci_acpi.c
86	It looks like I copied some incorrect code from sdhci_acpi. Since checking the UID is pointless, I will remove the UID field.
sys/dev/ufshci/ufshci_ctrlr.c
360	`clang-format15 -i sys/dev/ufshci/ufshci_ctrlr.c` Clang-format enforces this awkward indentation. Do you have any ideas for how to avoid it?
362	`clang-format15 -i sys/dev/ufshci/ufshci_ctrlr.c` Clang-format enforces this awkward indentation. Do you have any ideas for how to avoid it?