Page MenuHomeFreeBSD
Differential D55985

ufshci: add uic powermode parameter to sysctl
ClosedPublic
Actions

Authored by jaeyoon on Fri, Mar 20, 7:23 AM.
Tags
None
Referenced Files
F150320851: D55985.id174272.diff
Tue, Mar 31, 4:22 AM
Unknown Object (File)
Sun, Mar 29, 12:36 PM
Unknown Object (File)
Sun, Mar 29, 8:22 AM
Unknown Object (File)
Sun, Mar 29, 6:03 AM
Unknown Object (File)
Fri, Mar 27, 6:36 AM
Unknown Object (File)
Thu, Mar 26, 8:56 AM
Unknown Object (File)
Thu, Mar 26, 8:56 AM
Unknown Object (File)
Thu, Mar 26, 5:31 AM
View All 11 Files
Subscribers
ziaee

Details

Reviewers
imp
Commits
rG085028463fa9: ufshci: add uic powermode parameter to sysctl
Summary

Adds parameters related to the performance of the UFS device.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Fri, Mar 20, 7:23 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B71577: Diff 173995.Fri, Mar 20, 7:23 AM
jaeyoon added a parent revision: D55984: ufshci: fix bug in ufshci_req_sdb_enable.Fri, Mar 20, 7:24 AM
jaeyoon added a child revision: D55986: ufshci: Support ACPI.
imp accepted this revision.Fri, Mar 20, 1:39 PM

Is there documentation that needs to be updated?
The change itself looks good, though maybe the commit message is a little vague?

sys/dev/ufshci/ufshci_pci.c
37

I don't think you want this change...

This revision is now accepted and ready to land.Fri, Mar 20, 1:39 PM
jaeyoon updated this revision to Diff 174145.Mon, Mar 23, 2:36 AM

Modified the man page.

This revision now requires review to proceed.Mon, Mar 23, 2:36 AM
Herald added a subscriber: ziaee. · View Herald TranscriptMon, Mar 23, 2:36 AM
Harbormaster completed remote builds in B71657: Diff 174145.Mon, Mar 23, 2:36 AM
jaeyoon added a comment.Mon, Mar 23, 6:09 AM

Could you please approve this patch?

imp accepted this revision.Mon, Mar 23, 2:25 PM
This revision is now accepted and ready to land.Mon, Mar 23, 2:25 PM
jaeyoon marked an inline comment as done.Tue, Mar 24, 12:18 AM
jaeyoon added inline comments.
sys/dev/ufshci/ufshci_pci.c
37

Clang-format enforces this awkward indentation.

imp added a comment.Tue, Mar 24, 8:58 PM

OK. thanks for the info on clang-format. It's approved to commit.

Closed by commit rG085028463fa9: ufshci: add uic powermode parameter to sysctl (authored by jaeyoon). · Explain WhyWed, Mar 25, 4:47 AM
This revision was automatically updated to reflect the committed changes.
jaeyoon marked an inline comment as done.
jaeyoon added a commit: rG085028463fa9: ufshci: add uic powermode parameter to sysctl.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
34 lines
sys/
dev/
ufshci/
12 lines
3 lines
3 lines
35 lines

Diff 174272

View Options

share/man/man4/ufshci.4

Loading...
View Options

sys/dev/ufshci/ufshci_dev.c

Loading...
View Options

sys/dev/ufshci/ufshci_pci.c

Loading...
View Options

sys/dev/ufshci/ufshci_private.h

Loading...
View Options

sys/dev/ufshci/ufshci_sysctl.c

Loading...