ufshci: Support ACPI

[jaeyoon]

Summary

Supports UFS host controller attachment via ACPI. Tested on the
Samsung Galaxy Book 4 Edge using Qualcomm Snapdragon X Elite.
Additionally, a quirk related to power mode change has been added.

For reference, it doesn't reach maximum speed yet. I plan to improve
it later.

Sponsored by: Samsung Electronics

[imp]

sys/dev/ufshci/ufshci_acpi.c

85

why is 0 treated special here? Generically, 0 is a fine UID number. Is there some guarantee that we won't need to match on UID 0, but no others (the way the code is now is 0 matches all UID, which seems sensible... though I wonder why we ever care about the UID to do quirk matching).

sys/dev/ufshci/ufshci_ctrlr.c

125

Would this code be better in its own function, even if it is a singleton?

358

This might be better on one line, even if it pushes past 80 columns. The alignment shown in phab is weird, we usually just indent 4 extra spaces.

360

Here I'd definitely fold the lines. Going over 80 columns by 1 or 2 characters is preferable.

[jaeyoon]

Apply review comments.

[jaeyoon]

Thanks for the review!

sys/dev/ufshci/ufshci_acpi.c

85

It looks like I copied some incorrect code from sdhci_acpi. Since checking the UID is pointless, I will remove the UID field.

sys/dev/ufshci/ufshci_ctrlr.c

358

clang-format15 -i sys/dev/ufshci/ufshci_ctrlr.c

Clang-format enforces this awkward indentation. Do you have any ideas for how to avoid it?

360

clang-format15 -i sys/dev/ufshci/ufshci_ctrlr.c

Clang-format enforces this awkward indentation. Do you have any ideas for how to avoid it?

[imp]

If you are using clang-format, then go ahead and commit. I'm not sure how to get it to behave better in a way that isn't a big hack.