virtual_oss depends on cuse, is there a way to avoid building virtual_oss also if MK_CUSE is not set?

Why MK_VOSS and not MK_VIRTUAL_OSS? I also don't really understand the rationale... sound-related utilities are not needed on some platforms, ok, but why not have a more generic option that also lets you remove sndctl and mixer?

I think this option also needs to be listed in share/mk/src.opts.mk, and a description under tools/build/options for src.conf.5 generation.

In D54456#1244378, @christos wrote:

virtual_oss depends on cuse, is there a way to avoid building virtual_oss also if MK_CUSE is not set?

I think the "right" way is to add some logic to share/mk/src.opts.mk to force-disable MK_VOSS if MK_CUSE is disabled.

In D54456#1245671, @markj wrote:

Why MK_VOSS and not MK_VIRTUAL_OSS? I also don't really understand the rationale... sound-related utilities are not needed on some platforms, ok, but why not have a more generic option that also lets you remove sndctl and mixer?

This is an initial patch after a discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291853

In my opinion, it'd make more sense to have a general MK_SOUND control that will either build or not build any sound utilities, including sndctl(8), mixer(3 & 8), beep(1). Initially I also opposed the idea of creating an option specific to virtual_oss. What do you think?

Regarding "why VOSS and not VIRTUAL_OSS", I did it to be consistent with libexec/rc/rc.d/Makefile, but I guess we could just change that to VIRTUAL_OSS as well.

In D54456#1246812, @christos wrote:

In D54456#1245671, @markj wrote:

Why MK_VOSS and not MK_VIRTUAL_OSS? I also don't really understand the rationale... sound-related utilities are not needed on some platforms, ok, but why not have a more generic option that also lets you remove sndctl and mixer?

This is an initial patch after a discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291853

In my opinion, it'd make more sense to have a general MK_SOUND control that will either build or not build any sound utilities, including sndctl(8), mixer(3 & 8), beep(1). Initially I also opposed the idea of creating an option specific to virtual_oss. What do you think?

I think that makes more sense than having an option for just virtual_oss.

Regarding "why VOSS and not VIRTUAL_OSS", I did it to be consistent with libexec/rc/rc.d/Makefile, but I guess we could just change that to VIRTUAL_OSS as well.

That's just an internal name, private to the makefile.

@zarychtam_plan-b.pwste.edu.pl @rozhuk.im-gmail.com Opinions?

In D54456#1248939, @zarychtam_plan-b.pwste.edu.pl wrote:

Congratulations and thanks for this great solution! It's now 100% compatible with the "WITHOUT_MODULES sound" kernel build and install knob and covers the entire sound toolkit.

Glad to hear :)

This needs a description for WITHOUT_SOUND in tools/build/options