Paths

Table of Contentst

Differential D54643

bhyve: Refactor pci_irq_route
AcceptedPublic
Actions

Authored by bnovkov on Jan 11 2026, 1:32 PM.

Tags

None

Referenced Files

	F156981513: D54643.id169463.diff
	Sun, May 17, 7:04 PM

	Unknown Object (File)
	Wed, May 13, 8:29 PM

	Unknown Object (File)
	Wed, May 13, 7:46 PM

	Unknown Object (File)
	Wed, May 13, 7:46 PM

	Unknown Object (File)
	Wed, May 13, 7:28 PM

	Unknown Object (File)
	Tue, May 12, 11:48 PM

	Unknown Object (File)
	Mon, May 11, 5:43 AM

	Unknown Object (File)
	Mon, May 11, 5:14 AM

View All 48 Files

Subscribers

Details

Reviewers

andrew
markj

Group Reviewers

Summary

Change pci_irq_route's arguments to a slot number and a pin number
instead of a pointer to an emulated PCI device instance.
This allows us to set up fixed IRQ mappings for slots without device
instances, which is a prerequisite for device hotplugging.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69792
Build 66675: arc lint + arc unit

Event Timeline

bnovkov created this revision.Jan 11 2026, 1:32 PM

Herald added a reviewer: andrew. · View Herald TranscriptJan 11 2026, 1:32 PM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

bnovkov requested review of this revision.Jan 11 2026, 1:32 PM

Harbormaster completed remote builds in B69792: Diff 169463.Jan 11 2026, 1:32 PM

bnovkov added a parent revision: D54642: bhyve/pci_emul.c: Introduce notion of fixed and hotpluggable slots.Jan 11 2026, 1:32 PM

bnovkov added a child revision: D54644: bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slots.

Looks ok aside from the comments.

usr.sbin/bhyve/pci_emul.c
2156	What's the purpose of this change?
usr.sbin/bhyve/pci_irq.c
17	Extra newline

Address @markj 's comments.

usr.sbin/bhyve/pci_emul.c
2156	Ah, that was a leftover change from a previous version of this patch, removed.

markj accepted this revision as: markj.Feb 6 2026, 3:41 PM

This revision is now accepted and ready to land.Feb 6 2026, 3:41 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

1 line

aarch64/

	pci_irq_machdep.c
	pci_irq.c

6 lines

amd64/

2 lines

12 lines

	pci_irq_machdep.c
	pci_irq.c

11 lines

9 lines

4 lines

17 lines

riscv/

	pci_irq_machdep.c
	pci_irq.c

6 lines

Diff 169463

usr.sbin/bhyve/Makefile

Loading...

usr.sbin/bhyve/aarch64/pci_irq.c

Loading...

usr.sbin/bhyve/aarch64/pci_irq_machdep.c

Loading...

usr.sbin/bhyve/amd64/ioapic.h

Loading...

usr.sbin/bhyve/amd64/ioapic.c

Loading...

usr.sbin/bhyve/amd64/pci_irq.c

Loading...

usr.sbin/bhyve/amd64/pci_irq_machdep.c

Loading...

usr.sbin/bhyve/pci_emul.c

Loading...

usr.sbin/bhyve/pci_irq.h

Loading...

usr.sbin/bhyve/pci_irq.c

Loading...

usr.sbin/bhyve/riscv/pci_irq.c

Loading...

usr.sbin/bhyve/riscv/pci_irq_machdep.c

Loading...