Details

lib/libc/tests/stdbit/stdbit-test-framework.c
64	If I remove `ATF_TP_ADD_TCS`, the tests fail to build (undefined symbol `main`). If I just remove the individual test cases `ATF_TP_ADD_TC`, then no unit tests end up defined. I am confused as to which part of this is “no longer needed.” Please clarify.

fix formatting issues in stdbit unit tests

This revision now requires review to proceed.Nov 19 2025, 11:23 AM

Harbormaster completed remote builds in B68735: Diff 166764.Nov 19 2025, 11:23 AM

use _WIDTH macros from C23 <limits.h> in stdbit unit tests, see D53825

Harbormaster completed remote builds in B68740: Diff 166769.Nov 19 2025, 1:09 PM

I just remembered that you need to add an stdbit directory to etc/mtree/BSD.tests.mk:

--- a/etc/mtree/BSD.tests.dist
+++ b/etc/mtree/BSD.tests.dist
@@ -382,6 +382,8 @@
             ..
             ssp
             ..
+            stdbit
+            ..
             stdio
             ..
             stdlib

This revision now requires changes to proceed.Nov 19 2025, 2:05 PM

Thanks, this is something I always forget about.

etc/mtree: add stdbit directory to etc/mtree/BSD.tests.mk

Herald added a subscriber: ivy. · View Herald TranscriptNov 19 2025, 2:59 PM

Harbormaster completed remote builds in B68741: Diff 166775.Nov 19 2025, 2:59 PM

des accepted this revision.Nov 25 2025, 7:58 PM

This revision is now accepted and ready to land.Nov 25 2025, 7:58 PM

Approved

Closed by commit rG2fb8cbc6ef1b: libc/tests: add stdbit test framework and unit tests (authored by fuz). · Explain WhyNov 30 2025, 7:24 PM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rG2fb8cbc6ef1b: libc/tests: add stdbit test framework and unit tests.

fuz mentioned this in D54026: powerpc/_stdint.h: fix SIG_ATOMIC_{MIN,MAX,WIDTH}.Dec 2 2025, 2:38 AM

fuz added a commit: rGc9ec3fc0d507: libc/tests: add stdbit test framework and unit tests.Jan 1 2026, 10:28 PM

libc/tests: add stdbit test framework and unit tests
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 166775

etc/mtree/BSD.tests.dist

lib/libc/tests/Makefile

lib/libc/tests/stdbit/Makefile

lib/libc/tests/stdbit/stdbit-test-framework.c

lib/libc/tests/stdbit/stdbit-test-kernel.c

lib/libc/tests/stdbit/stdc_bit_ceil_test.c

lib/libc/tests/stdbit/stdc_bit_floor_test.c

lib/libc/tests/stdbit/stdc_bit_width_test.c

lib/libc/tests/stdbit/stdc_count_ones_test.c

lib/libc/tests/stdbit/stdc_count_zeros_test.c

lib/libc/tests/stdbit/stdc_first_leading_one_test.c

lib/libc/tests/stdbit/stdc_first_leading_zero_test.c

lib/libc/tests/stdbit/stdc_first_trailing_one_test.c

lib/libc/tests/stdbit/stdc_first_trailing_zero_test.c

lib/libc/tests/stdbit/stdc_has_single_bit_test.c

lib/libc/tests/stdbit/stdc_leading_ones_test.c

lib/libc/tests/stdbit/stdc_leading_zeros_test.c

lib/libc/tests/stdbit/stdc_trailing_ones_test.c

lib/libc/tests/stdbit/stdc_trailing_zeros_test.c

libc/tests: add stdbit test framework and unit testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 166775

etc/mtree/BSD.tests.dist

lib/libc/tests/Makefile

lib/libc/tests/stdbit/Makefile

lib/libc/tests/stdbit/stdbit-test-framework.c

lib/libc/tests/stdbit/stdbit-test-kernel.c

lib/libc/tests/stdbit/stdc_bit_ceil_test.c

lib/libc/tests/stdbit/stdc_bit_floor_test.c

lib/libc/tests/stdbit/stdc_bit_width_test.c

lib/libc/tests/stdbit/stdc_count_ones_test.c

lib/libc/tests/stdbit/stdc_count_zeros_test.c

lib/libc/tests/stdbit/stdc_first_leading_one_test.c

lib/libc/tests/stdbit/stdc_first_leading_zero_test.c

lib/libc/tests/stdbit/stdc_first_trailing_one_test.c

lib/libc/tests/stdbit/stdc_first_trailing_zero_test.c

lib/libc/tests/stdbit/stdc_has_single_bit_test.c

lib/libc/tests/stdbit/stdc_leading_ones_test.c

lib/libc/tests/stdbit/stdc_leading_zeros_test.c

lib/libc/tests/stdbit/stdc_trailing_ones_test.c

lib/libc/tests/stdbit/stdc_trailing_zeros_test.c

libc/tests: add stdbit test framework and unit tests
ClosedPublic
Actions

Revision Contents
Changeset List