Differential D53658

man/man3: add stdbit.3
ClosedPublic
Actions

Authored by fuz on Nov 10 2025, 9:32 AM.

Tags

None

Referenced Files

	F141985502: D53658.id166128.diff
	Wed, Jan 14, 12:48 PM

	F141980244: D53658.id166240.diff
	Wed, Jan 14, 11:38 AM

	Unknown Object (File)
	Mon, Jan 12, 10:15 AM

	Unknown Object (File)
	Fri, Jan 2, 12:33 AM

	Unknown Object (File)
	Thu, Jan 1, 10:21 PM

	Unknown Object (File)
	Tue, Dec 30, 12:36 AM

	Unknown Object (File)
	Mon, Dec 22, 10:42 PM

	Unknown Object (File)
	Mon, Dec 22, 2:43 AM

View All 51 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

markj
adrian

Group Reviewers

Commits

rG6b7ed283d4b4: man/man3: add stdbit.3
rGd39e310c7d6a: man/man3: add stdbit.3

Summary

This is the overview man page for the <stdbit.h> functions.
Individual man pages will follow in a later DR.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz created this revision.Nov 10 2025, 9:32 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptNov 10 2025, 9:32 AM

fuz requested review of this revision.Nov 10 2025, 9:32 AM

Harbormaster completed remote builds in B68498: Diff 166112.Nov 10 2025, 9:32 AM

fuz added a parent revision: D53657: libc: implement C23 <stdbit.h> functions.Nov 10 2025, 9:35 AM

fuz added a child revision: D53659: libc/stdbit: add man pages for stdbit functions.

This is awesome!

share/man/man3/stdbit.3
4	The license block has blank comments at the top and bottom (before 1 and after 3).
11	The .Sh LIBRARY section is deprecated, .Lb libc now goes at the top of .Sh SYNOPSIS

stdbit.3: address ziaee's review comments

Harbormaster completed remote builds in B68506: Diff 166128.Nov 10 2025, 2:12 PM

fuz mentioned this in D53659: libc/stdbit: add man pages for stdbit functions.Nov 10 2025, 2:22 PM

stdbit.3: remove - from \"-

Harbormaster completed remote builds in B68542: Diff 166240.Nov 11 2025, 3:50 PM

English looks good to me. Can't speak to the rest.

kib added a subscriber: kib.Nov 12 2025, 5:05 AM

kib added inline comments.

share/man/man3/stdbit.3
12	May be, 'Standard 2023 C bit and byte utilties'?
52
56
96	Why these (stdc_*) functions are listed in the 'SEE ALSO' section? First, there is no separate man pages for each of them. Second, isn't this man page is supposed to document them?

fuz added inline comments.Nov 12 2025, 10:36 AM

share/man/man3/stdbit.3
12	I don't see why it's important to point out that this header was added in C23. It's not like we say that anywhere else.
56	I would prefer to leave the sentence in, as it clarifies the behaviour on platforms where there are indeed other byte orders. The new sentence is useful, I'll add that in.
96	D53659 adds man pages for all these functions. There are 70 functions and 14 type-generic macros in total, so I thought it would be more useful to have an individual page for each.

kib added inline comments.Nov 14 2025, 1:11 AM

share/man/man3/stdbit.3
12	To direct people to where look for further reference about the functions.
96	Ok.

ziaee added inline comments.Nov 14 2025, 1:22 AM

share/man/man3/stdbit.3
12	We usually handle this with a STANDARDS section

fuz mentioned this in D53657: libc: implement C23 <stdbit.h> functions.Nov 18 2025, 2:43 PM

looks good, maybe get a review from @ziaee too for manpage stuff and then land?

This revision is now accepted and ready to land.Nov 18 2025, 3:03 PM

Approved

Closed by commit rGd39e310c7d6a: man/man3: add stdbit.3 (authored by fuz). · Explain WhyNov 30 2025, 7:24 PM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rGd39e310c7d6a: man/man3: add stdbit.3.

fuz added a commit: rG6b7ed283d4b4: man/man3: add stdbit.3.Thu, Jan 1, 10:22 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man3/

1 line

120 lines

Diff 167328

share/man/man3/Makefile

Loading...

share/man/man3/stdbit.3

Loading...