Differential D53781

iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately
ClosedPublic
Actions

Authored by adrian on Nov 16 2025, 4:30 AM.

Details

Reviewers

None

Group Reviewers

wireless

Commits

rG4d29178e7154: iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately

Summary

tag packets for 11n/11ac associated nodes with A_MPDU so they get passed into the reordering logic

tag A-MSDU frames with AMSDU and AMSDU_MORE so they don't get dropped due to duplicate sequence numbers.

Note: I haven't yet elicited A-MSDU in A-MPDU to fully test this,
but I do see the net80211 reordering logic kick in (which you can
see via wlanstats -i wlan0 -o ampdu 1); so although maybe on
some firmware / hardware versions we're supposed to get fully
in-sequence RX, at least on my AX210 I'm not.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68676
Build 65559: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 16 2025, 4:30 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2025, 4:30 AM

adrian requested review of this revision.Nov 16 2025, 4:30 AM

Harbormaster completed remote builds in B68676: Diff 166540.Nov 16 2025, 4:30 AM

adrian added a parent revision: D53780: iwx: clean up / document noise floor and RSSI fetching.Nov 16 2025, 4:31 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

Are you sure you are not getting full reassembled (re-aggregated) frames on your AX210 that better sees no sequence number checks in net80211 anymore?

Just dropping a note that this leads to ~10x throughput to pkg.f.o on my laptop -- previously averaging somewhere around ~2-3mbit/s due to constant out-of-order acks, up to ~25-30 mbit/s on average

This revision was not accepted when it landed; it landed in state Needs Review.Nov 21 2025, 7:11 AM

Closed by commit rG4d29178e7154: iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG4d29178e7154: iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately.

adrian added a child revision: D54390: net80211: clean up time comparison in HT code.Dec 29 2025, 4:58 AM