iwx: clean up TX AMPDU session establishment and checking
ClosedPublic
Actions

Authored by adrian on Thu, Nov 13, 4:36 AM.

Details

Reviewers

thj

Group Reviewers

wireless

Commits

Summary

iwx: clean up TX AMPDU session establishment and checking

Send a TX AMPDU exchange successfully; we were allocating the AMPDU TX queue but returning 0 to net80211 was telling it to not establish the TX AMPDU session and none of the BA session tracking stuff would work.

Clean up the TX AMPDU queue lookup in the transmit path - only QoS data frames are allowed, not qos null-data, cf/ack/etc frames; only send them if the AMPDU session is established.

Tell net80211 that we've established the TX AMPDU session once the firmware queue has been created.

Check to make sure we're not double (or more) creating TX AMDPU sessions - only allocate a qid if we're not doing AMPDU yet.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68624
Build 65507: arc lint + arc unit

adrian requested review of this revision.Thu, Nov 13, 4:36 AM

adrian added reviewers: wireless, thj.

adrian added a project: wireless.

more "correct" fixes, i hope!

adrian edited the summary of this revision. (Show Details)

thj accepted this revision.Thu, Nov 13, 9:26 AM

This revision is now accepted and ready to land.Thu, Nov 13, 9:26 AM

I am reluctant to click on Request Changes for this but maybe you can still fix the local bits before committing.

It's A-MPDU not AMPDU. sed-replace

sys/dev/iwx/if_iwx.c
3528	could be an uint8_t or if you really wanted an uint16_t
3557	We need to get rid of the magic number. I guess even a bool passing true or defining 1 to something in net80211 will do us good.
10962	/* * There is ...